PoC for extending the official Databricks extension - #94
Closed
fjakobs wants to merge 1 commit into
Closed
Conversation
Collaborator
|
I would not want to ditch all current connection managers as it would break all existing installations/configurations. Instead the new connection manager should be selectable as the existing ones are
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Fabian Jakobs ***@***.***>
Sent: Wednesday, September 14, 2022 11:09:37 AM
To: paiqo/Databricks-VSCode ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [paiqo/Databricks-VSCode] PoC for extending the official Databricks extension (PR #94)
This adds a dependency to the official Databricks extension and uses the exported API to fetch the configuration from there.
[Screenshot 2022-09-14 at 11 03 53]<https://user-images.githubusercontent.com/40952/190112237-52b3b2b1-c37c-4294-b540-6826293c87db.png>
________________________________
You can view, comment on, or merge this pull request online at:
#94
Commit Summary
* 4af05b8<4af05b8> PoC for extending the official Databricks extension
File Changes
(5 files<https://github.com/paiqo/Databricks-VSCode/pull/94/files>)
* M package-lock.json<https://github.com/paiqo/Databricks-VSCode/pull/94/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519> (163)
* M package.json<https://github.com/paiqo/Databricks-VSCode/pull/94/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519> (18)
* M src/ThisExtension.ts<https://github.com/paiqo/Databricks-VSCode/pull/94/files#diff-8579c7c6a7288900433b7fb92eecb227c1e15fb78e7979445f8736cb1e3e8d69> (27)
* M src/extension.ts<https://github.com/paiqo/Databricks-VSCode/pull/94/files#diff-04bba6a35cad1c794cbbe677678a51de13441b7a6ee8592b7b50be1f05c6f626> (6)
* A src/vscode/treeviews/connections/DatabricksConnectionManagerBricks.ts<https://github.com/paiqo/Databricks-VSCode/pull/94/files#diff-5a9706ee59d746686e39d6ab26aec4ffa2a1cb43c7c9397852e33e44ec55d911> (54)
Patch Links:
* https://github.com/paiqo/Databricks-VSCode/pull/94.patch
* https://github.com/paiqo/Databricks-VSCode/pull/94.diff
—
Reply to this email directly, view it on GitHub<#94>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC2VO4V4JOCS3R5FFXJX7TTV6GI5DANCNFSM6AAAAAAQMGPQRI>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Contributor
Author
|
This PR is mostly for demonstration purposes to se how the relationship between the two extension could look like. Commenting out the config code was just the fasted path for getting there. |
Collaborator
|
Well I cannot merge this into master as you probably understand. |
fjakobs
added a commit
to databricks/databricks-vscode
that referenced
this pull request
Sep 14, 2022
See also paiqo/Databricks-VSCode#94 for how this API can be consumed. 
Contributor
Author
|
Sorry for the confusion - this was never intended for being merged as is into master. This was just to show how cross extension communication might work. |
Collaborator
|
I guess you would also need to share the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a dependency to the official Databricks extension and uses the exported API to fetch the configuration from there.