[2/n] [dropshot] add tests for valid configs - #1172
Merged
sunshowers merged 5 commits intoNov 15, 2024
Merged
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
sunshowers
changed the title
This was referenced Nov 12, 2024
ahl
approved these changes
Nov 15, 2024
sunshowers
changed the base branch from
sunshowers/spr/main.23-dropshot-add-tests-for-valid-configs
to
main
November 15, 2024 22:47
Created using spr 1.3.6-beta.1
sunshowers
enabled auto-merge (squash)
November 15, 2024 22:52
sunshowers
deleted the
sunshowers/spr/23-dropshot-add-tests-for-valid-configs
branch
November 15, 2024 22:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally broke one of these in a subsequent commit, so add a commit with
some tests before making that change.
Depends on: