Update properties table#2723
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
reviewed
Mar 3, 2025
| { | ||
| 'lg+:grid-cols-[minmax(min-content,1fr)_3fr_minmax(min-content,1fr)_3fr] lg+:[&>*:nth-child(-n+4)]:!border-t-0 lg+:[&>*:nth-child(4n-2)]:border-r': | ||
| columns === 2, | ||
| } |
Collaborator
There was a problem hiding this comment.
I'll take your word for it
david-crespo
approved these changes
Mar 3, 2025
Collaborator
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
Love it, looks great. The stupid test flakes may prevent merge. I will probably override them for now.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Mar 4, 2025
oxidecomputer/console@a3566bd...eed4a4e * [eed4a4e7](oxidecomputer/console@eed4a4e7) gitigore .react-router/ * [a8ac33f6](oxidecomputer/console@a8ac33f6) design-system 2.3 for icon build rework * [b50269c3](oxidecomputer/console@b50269c3) oxidecomputer/console#2743 * [d07c69ca](oxidecomputer/console@d07c69ca) oxidecomputer/console#2744 * [59818128](oxidecomputer/console@59818128) oxidecomputer/console#2741 * [1fe4a7ec](oxidecomputer/console@1fe4a7ec) minor: remove indirection in router edit onDismiss * [718244d2](oxidecomputer/console@718244d2) minor: redirectWithLoader helper * [0db9e4c8](oxidecomputer/console@0db9e4c8) oxidecomputer/console#2720 * [97869a79](oxidecomputer/console@97869a79) oxidecomputer/console#2731 * [bca35b85](oxidecomputer/console@bca35b85) debug ci e2e script uses fzf * [516a375d](oxidecomputer/console@516a375d) oxidecomputer/console#2727 * [873e898f](oxidecomputer/console@873e898f) oxidecomputer/console#2724 * [46f14c21](oxidecomputer/console@46f14c21) oxidecomputer/console#2729 * [a64dbb8a](oxidecomputer/console@a64dbb8a) oxidecomputer/console#2723 * [7410850d](oxidecomputer/console@7410850d) chore: fix lint error, sorry * [6985f5dd](oxidecomputer/console@6985f5dd) oxidecomputer/console#2708 * [abcda05b](oxidecomputer/console@abcda05b) tools: deploy dogfood script accepts any git ref
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Mar 4, 2025
oxidecomputer/console@a3566bd...eed4a4e * [eed4a4e7](oxidecomputer/console@eed4a4e7) gitigore .react-router/ * [a8ac33f6](oxidecomputer/console@a8ac33f6) design-system 2.3 for icon build rework * [b50269c3](oxidecomputer/console@b50269c3) oxidecomputer/console#2743 * [d07c69ca](oxidecomputer/console@d07c69ca) oxidecomputer/console#2744 * [59818128](oxidecomputer/console@59818128) oxidecomputer/console#2741 * [1fe4a7ec](oxidecomputer/console@1fe4a7ec) minor: remove indirection in router edit onDismiss * [718244d2](oxidecomputer/console@718244d2) minor: redirectWithLoader helper * [0db9e4c8](oxidecomputer/console@0db9e4c8) oxidecomputer/console#2720 * [97869a79](oxidecomputer/console@97869a79) oxidecomputer/console#2731 * [bca35b85](oxidecomputer/console@bca35b85) debug ci e2e script uses fzf * [516a375d](oxidecomputer/console@516a375d) oxidecomputer/console#2727 * [873e898f](oxidecomputer/console@873e898f) oxidecomputer/console#2724 * [46f14c21](oxidecomputer/console@46f14c21) oxidecomputer/console#2729 * [a64dbb8a](oxidecomputer/console@a64dbb8a) oxidecomputer/console#2723 * [7410850d](oxidecomputer/console@7410850d) chore: fix lint error, sorry * [6985f5dd](oxidecomputer/console@6985f5dd) oxidecomputer/console#2708 * [abcda05b](oxidecomputer/console@abcda05b) tools: deploy dogfood script accepts any git ref
This was referenced Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2722
Bonus fix of this joined two column properties table is we automatically get the label columns matching width when it wraps on smaller screens.
Inline grid stuff maybe isn't the most readable, but doing it in a mix of externally in the CSS I always find confusing. Perhaps fixable with some utility classes.
Slightly narrower so it doesn't take so much space, especially on the side panes.
Pretty much ready to review, I need to poke around all the usages to check for any regressions.