Update database prefix documentation to be more detailed - #143
Conversation
7731026 to
03a25b3
Compare
|
Alternatively, we can embed the same information in the description field using |
oliverchang
left a comment
oliverchang
left a comment
There was a problem hiding this comment.
thanks for starting this! some comments/questions here.
6a41d11 to
ef406d4
Compare
|
That's odd...I amended my commit with the sign-off, and the build is still failing...? Edit: I missed a commit before my merge commit. It was easiest to just redo my history with a soft reset and sign off on that. |
Rather than a generic description, updated the table to provide more specific (and actionable) information: - Prefix - Database Name / Source URL - Canonical URL for a given <ID> - API Endpoint for a given <ID> - Regex for the ID May not be fully complete or accurate, but should provide more actionable guidance for OSV consumers and producers. Signed-off-by: Josh Buker <crypto@joshbuker.com>
ef406d4 to
82c67c5
Compare
Signed-off-by: Josh Buker <crypto@joshbuker.com>
c569cba to
e398682
Compare
oliverchang
left a comment
oliverchang
left a comment
There was a problem hiding this comment.
Thanks! This LGTM. I added two commits filling in some contribution links and OSV URLs though. Let me know if you agree.
|
@oliverchang Heads up that you missed the sign-off on your commits. LGTM, I'll add https://gsd.id/getting-started for how to contribute to GSD (docs are WIP) after your commits are fixed, but otherwise don't see any issues. |
Yep I messed up there :) Merging ! |
2 participants
Rather than a generic description, updated the table to provide more specific (and actionable) information:
May not be fully complete or accurate, but should provide more actionable guidance for OSV consumers and producers.