Skip to content

Pass command line arguments in context init method#45

Merged
ivanpauno merged 4 commits into
galactic-develfrom
ivanpauno/init-with-args
Sep 29, 2020
Merged

Pass command line arguments in context init method#45
ivanpauno merged 4 commits into
galactic-develfrom
ivanpauno/init-with-args

Conversation

@ivanpauno
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Sep 25, 2020
@ivanpauno ivanpauno self-assigned this Sep 25, 2020
@ivanpauno ivanpauno changed the title Initialize context passing command line arguments Pass command line arguments in context init method Sep 28, 2020
Copy link
Copy Markdown

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a couple minor comments.

Comment thread rcljava/src/main/cpp/org_ros2_rcljava_contexts_ContextImpl.cpp Outdated
Comment thread rcljava/src/main/java/org/ros2/rcljava/contexts/Context.java Outdated
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno merged commit 230a061 into galactic-devel Sep 29, 2020
@ivanpauno ivanpauno deleted the ivanpauno/init-with-args branch September 29, 2020 20:43
ivanpauno added a commit that referenced this pull request May 17, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 13, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 13, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 13, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 17, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants