Skip to content

chore(release): bump to 2.1.3. #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeproeng37 merged 5 commits into from
Aug 22, 2018
Merged

chore(release): bump to 2.1.3. #156

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3fc749
Bump to 2.1.2.
Aug 21, 2018
61db46a
Add missing paren to changelog entry.
Aug 21, 2018
1c85faf
Include previous 2.1.2 version and update to 2.1.3 instead.
Aug 22, 2018
7f36279
Add missing link to deprecated log entry.
Aug 22, 2018
84cca27
Remove unreleased section as it is not populated.
Aug 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/optimizely-sdk/CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Deprecated

@spencerwilson-optimizely spencerwilson-optimizely Aug 21, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the stuff under Unreleased into the new 2.2.0 entry.

* The UMD build of the SDK now assigns the SDK namespace object to `window.optimizelySdk` rather than to `window.optimizelyClient`. The old name still works, but on its first access a deprecation warning is logged to the console. The alias will be removed in the 3.0.0 release.

## [2.1.2] - August 21, 2018

@spencerwilson-optimizely spencerwilson-optimizely Aug 21, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this release is 2.2.0. The current release on npm is 2.1.2.

@mikeproeng37 mikeproeng37 Aug 21, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:( this means the current production package is sending the wrong version. Nice catch though. I'd argue for 2.1.3 because we aren't introducing any new features, at least that's what we've been using as a basis for minor version bumps.

@tylerbrandt tylerbrandt Aug 21, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I bumped the version in v2.1.x branch only (#126), since that's the only place the patch version is relevant.

@spencerwilson-optimizely spencerwilson-optimizely Aug 21, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean that the changelog entry for 2.1.2 never escapes the v2.1.x branch? That's not good :\

@tylerbrandt tylerbrandt Aug 22, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog is correct/complete on all released tags, at least (none of which are defined in master). I can see the argument for keeping master up-to-date with the "current" branch though, so we can change it.


### Fixed
- Send all decisions for the same event in one snapshot. ([#155](https://github.com/optimizely/javascript-sdk/pull/155))
- Give Node.js consumers the unbundled package ([#133](https://github.com/optimizely/javascript-sdk/pull/133))
- Prevent crash when `http`/`https` emits an error by adding an 'error' listener ([#123](https://github.com/optimizely/javascript-sdk/pull/123))

## 2.1.1
June 19, 2018

Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/enums/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ exports.CONTROL_ATTRIBUTES = {

exports.JAVASCRIPT_CLIENT_ENGINE = 'javascript-sdk';
exports.NODE_CLIENT_ENGINE = 'node-sdk';
exports.NODE_CLIENT_VERSION = '2.1.1';
exports.NODE_CLIENT_VERSION = '2.1.2';

/*
* Notification types for use with NotificationCenter
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@optimizely/optimizely-sdk",
"version": "2.1.1",
"version": "2.1.2",
"description": "JavaScript SDK for Optimizely X Full Stack",
"main": "lib/index.node.js",
"browser": "lib/index.browser.js",
Expand Down