Port feature gate promotion logic from o/api to sippy

cmd/sippy/seed_data.go

@@ -214,6 +214,7 @@ const awsAmd64Parallel = "periodic-ci-openshift-release-master-ci-%s-e2e-aws-ovn
 const awsArm64Parallel = "periodic-ci-openshift-release-master-ci-%s-e2e-aws-ovn-arm64"
 const gcpAmd64Parallel = "periodic-ci-openshift-release-master-ci-%s-e2e-gcp-ovn-amd64"
 const awsAmd64CapabilityAWSDualStackInstall = "periodic-ci-openshift-release-master-ci-%s-e2e-aws-ovn-amd64-capability-awsdualstackinstall"
+const awsAmd64CapabilityNetworkSegmentation = "periodic-ci-openshift-release-master-ci-%s-e2e-aws-ovn-amd64-capability-networksegmentation"
 const azureAmd64Parallel = "periodic-ci-openshift-release-master-ci-%s-e2e-azure-ovn-amd64"
 
 // allJobTemplates returns name templates from syntheticJobs for use in test specs
@@ -383,7 +384,7 @@ var syntheticTests = []syntheticTestSpec{
 		},
 	},
 	{
-		testID: "test-fg-aws-dual-stack-install", testName: "[sig-installer] [FeatureGate:AWSDualStackInstall] dual stack install should succeed",
+		testID: "test-fg-aws-dual-stack-install", testName: "[sig-installer] [FeatureGate:AWSDualStackInstall] specific test for the dual stack install feature",
 		component: "Installer / openshift-installer", capabilities: []string{"AWSDualStackInstall"},
 		jobCounts: map[string]map[string]testCount{
 			awsAmd64Parallel: {"4.22": {50, 48, 0}},
@@ -406,6 +407,29 @@ var syntheticTests = []syntheticTestSpec{
 		},
 	},
 
+	// --- Capability regression tests: tests on capability jobs with low pass rates ---
+	{
+		testID: "test-cap-regression-netseg", testName: "[sig-network] network connectivity should be reliable across nodes",
+		component: "Networking / ovn-kubernetes", capabilities: []string{"networking"},
+		jobCounts: map[string]map[string]testCount{
+			awsAmd64CapabilityNetworkSegmentation: {"4.22": {100, 85, 0}},
+		},
+	},
+	{
+		testID: "test-cap-regression-unpromoted-gate", testName: "[sig-network] [OCPFeatureGate:UnpromotedTestGate] should handle traffic correctly",
+		component: "Networking / ovn-kubernetes", capabilities: []string{"networking"},
+		jobCounts: map[string]map[string]testCount{
+			awsAmd64CapabilityNetworkSegmentation: {"4.22": {100, 80, 0}},
+		},
+	},
+	{
+		testID: "test-cap-regression-awsdualstack", testName: "[sig-network] dual stack services should route correctly",
+		component: "Networking / ovn-kubernetes", capabilities: []string{"networking"},
+		jobCounts: map[string]map[string]testCount{
+			awsAmd64CapabilityAWSDualStackInstall: {"4.22": {100, 88, 0}},
+		},
+	},
+
 	// --- Install / health indicator tests: run on every job, every release ---
 	{
 		testID: "test-install-overall", testName: "install should succeed: overall",
@@ -1319,6 +1343,8 @@ func seedFeatureGates(dbc *db.DB) error {
 	featureGates := []models.FeatureGate{
 		{Release: "4.22", Topology: "SelfManagedHA", FeatureSet: "TechPreviewNoUpgrade", FeatureGate: "NetworkSegmentation", Status: "enabled"},
 		{Release: "4.22", Topology: "SelfManagedHA", FeatureSet: "TechPreviewNoUpgrade", FeatureGate: "AWSDualStackInstall", Status: "enabled"},
+		{Release: "4.22", Topology: "SelfManagedHA", FeatureSet: "TechPreviewNoUpgrade", FeatureGate: "UnpromotedTestGate", Status: "enabled"},
+		{Release: "4.22", Topology: "SelfManagedHA", FeatureSet: "Default", FeatureGate: "PromotedTestGate", Status: "enabled"},
 	}
 
 	for _, fg := range featureGates {

pkg/api/README.md

@@ -580,3 +580,37 @@ tables don't carry a lifecycle column.
 ```
 
 </details>
+
+## Feature Gates
+
+### List Feature Gates
+
+Endpoint: `/api/feature_gates`
+
+Returns all feature gates and their test counts for a release. Each gate includes
+lightweight HATEOAS links (`ui_detail` and `api_detail`) for navigation.
+
+| Option   | Type   | Description                                              |
+|----------|--------|----------------------------------------------------------|
+| release* | String | The OpenShift release to return results from (e.g., 5.0) |
+| filter   | Filter | Filters the results. See filtering above.                |
+
+### Feature Gate Detail
+
+Endpoint: `/api/feature_gates/{feature_gate}`
+
+Returns a single feature gate with full HATEOAS links for test queries
+(`gate_tests`, `install_tests`, `gate_job_tests`, `ui_detail`).
+The `install_tests` link is only present for gates whose name contains "Install".
+
+The response includes a `promotion` object with promotion readiness data:
+per-variant test pass rates, overall sufficiency, warnings, and errors.
+The promotion evaluation is computed from the same data that the `gate_tests`
+and `install_tests` HATEOAS links point to. Both the links and the promotion
+logic use canonical filter definitions from
+`pkg/api/featuregatepromotion/filters.go`, ensuring they always stay in sync.
+
+| Option        | Type   | Description                                              |
+|---------------|--------|----------------------------------------------------------|
+| release*      | String | The OpenShift release to return results from (e.g., 5.0) |
+| feature_gate  | Path   | The feature gate name (in the URL path)                  |

pkg/api/featuregatepromotion/filters.go

@@ -0,0 +1,56 @@
+package featuregatepromotion
+
+import (
+	"fmt"
+
+	"github.com/openshift/sippy/pkg/filter"
+)
+
+// GateTestFilter returns the canonical filter for annotation-based tests
+// belonging to a feature gate. This is the authoritative definition used both
+// to generate HATEOAS links and to query data for promotion evaluation.
+func GateTestFilter(featureGate string) filter.Filter {
+	return filter.Filter{
+		Items: []filter.FilterItem{
+			{Field: "name", Operator: filter.OperatorContains, Value: fmt.Sprintf("FeatureGate:%s]", featureGate)},
+			{Field: "variants", Not: true, Operator: filter.OperatorHasEntry, Value: "never-stable"},
+			{Field: "variants", Not: true, Operator: filter.OperatorHasEntry, Value: "aggregated"},
+		},
+		LinkOperator: filter.LinkOperatorAnd,
+	}
+}
+
+// InstallTestFilter returns the canonical filter for install capability tests
+// belonging to an Install feature gate. Only applicable when the feature gate
+// name contains "Install". This is the authoritative definition used both
+// to generate HATEOAS links and to query data for promotion evaluation.
+func InstallTestFilter(featureGate string) filter.Filter {
+	return filter.Filter{
+		Items: []filter.FilterItem{
+			{Field: "name", Operator: filter.OperatorContains, Value: "install should succeed"},
+			{Field: "variants", Operator: filter.OperatorHasEntry, Value: fmt.Sprintf("Capability:%s", featureGate)},
+			{Field: "variants", Not: true, Operator: filter.OperatorHasEntry, Value: "never-stable"},
+			{Field: "variants", Not: true, Operator: filter.OperatorHasEntry, Value: "aggregated"},
+		},
+		LinkOperator: filter.LinkOperatorAnd,
+	}
+}
+
+// CapabilityRegressionsFilter returns the filter for identifying tests with
+// low pass rates on jobs owned by this feature gate's capability.
+func CapabilityRegressionsFilter(featureGate string) filter.Filter {
+	return filter.Filter{
+		Items: []filter.FilterItem{
+			{Field: "variants", Not: true, Operator: filter.OperatorHasEntry, Value: "never-stable"},
+			{Field: "variants", Not: true, Operator: filter.OperatorHasEntry, Value: "aggregated"},
+			{Field: "variants", Operator: filter.OperatorHasEntry, Value: fmt.Sprintf("Capability:%s", featureGate)},
+			{Field: "lifecycle", Operator: filter.OperatorEquals, Value: "blocking"},
+			{Field: "current_working_percentage", Operator: filter.OperatorArithmeticLessThan, Value: "92"},
+			{Field: "current_runs", Operator: filter.OperatorArithmeticGreaterThanOrEquals, Value: "1"},
+			{Field: "name", Not: true, Operator: filter.OperatorContains, Value: "install should succeed"},
+			{Field: "name", Not: true, Operator: filter.OperatorContains, Value: "openshift-tests should work"},
+			{Field: "name", Not: true, Operator: filter.OperatorContains, Value: "infrastructure should work"},
+		},
+		LinkOperator: filter.LinkOperatorAnd,
+	}
+}