NO-JIRA: HCP AutoNode e2e test changes - #68109
Conversation
|
@maxcao13: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-autonode pull-ci-openshift-hypershift-main-e2e-aws-karpenter-core |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
5ea428f to
57d57e0
Compare
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-autonode pull-ci-openshift-hypershift-main-e2e-aws-karpenter-core |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Reverts the hcp karpenter-core e2e tests and removes it. As of now, running this test does not work because our downstream was rebased to a point at which the test functionality is not compatible. Since the tests were not testing anything the current HCP native tests are not already testing, it makes sense to remove it altogether. Once the karpenter core downstream get's rebased to a more up to date version with a lot more comprehensive suites and compatibility, it will make sense to come back and re-enable this. Additionally, the split-client bifurcation and API namespacing work for karpenter will leave a lot of the current test setup for this particular job to have to be reworked. Signed-off-by: Max Cao <macao@redhat.com>
57d57e0 to
f06d1ef
Compare
|
@maxcao13, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@maxcao13: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Adding a ci job that only exercises the karpenter specific test to reduce time and cost when running/re-running. Signed-off-by: Max Cao <macao@redhat.com>
f06d1ef to
4af4ac9
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@maxcao13: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Thanks Max, this should make the red go away while we get our house in order. And hey, you put it in, they should let you take it back out, right? 😄 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkyros, maxcao13, muraee The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@maxcao13: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
* autonode: revert hcp karpenter e2e core test Reverts the hcp karpenter-core e2e tests and removes it. As of now, running this test does not work because our downstream was rebased to a point at which the test functionality is not compatible. Since the tests were not testing anything the current HCP native tests are not already testing, it makes sense to remove it altogether. Once the karpenter core downstream get's rebased to a more up to date version with a lot more comprehensive suites and compatibility, it will make sense to come back and re-enable this. Additionally, the split-client bifurcation and API namespacing work for karpenter will leave a lot of the current test setup for this particular job to have to be reworked. Signed-off-by: Max Cao <macao@redhat.com> * autonode: add optional autonode/karpenter specific test to hcp suite Adding a ci job that only exercises the karpenter specific test to reduce time and cost when running/re-running. Signed-off-by: Max Cao <macao@redhat.com> --------- Signed-off-by: Max Cao <macao@redhat.com>
* autonode: revert hcp karpenter e2e core test Reverts the hcp karpenter-core e2e tests and removes it. As of now, running this test does not work because our downstream was rebased to a point at which the test functionality is not compatible. Since the tests were not testing anything the current HCP native tests are not already testing, it makes sense to remove it altogether. Once the karpenter core downstream get's rebased to a more up to date version with a lot more comprehensive suites and compatibility, it will make sense to come back and re-enable this. Additionally, the split-client bifurcation and API namespacing work for karpenter will leave a lot of the current test setup for this particular job to have to be reworked. Signed-off-by: Max Cao <macao@redhat.com> * autonode: add optional autonode/karpenter specific test to hcp suite Adding a ci job that only exercises the karpenter specific test to reduce time and cost when running/re-running. Signed-off-by: Max Cao <macao@redhat.com> --------- Signed-off-by: Max Cao <macao@redhat.com>
* autonode: revert hcp karpenter e2e core test Reverts the hcp karpenter-core e2e tests and removes it. As of now, running this test does not work because our downstream was rebased to a point at which the test functionality is not compatible. Since the tests were not testing anything the current HCP native tests are not already testing, it makes sense to remove it altogether. Once the karpenter core downstream get's rebased to a more up to date version with a lot more comprehensive suites and compatibility, it will make sense to come back and re-enable this. Additionally, the split-client bifurcation and API namespacing work for karpenter will leave a lot of the current test setup for this particular job to have to be reworked. Signed-off-by: Max Cao <macao@redhat.com> * autonode: add optional autonode/karpenter specific test to hcp suite Adding a ci job that only exercises the karpenter specific test to reduce time and cost when running/re-running. Signed-off-by: Max Cao <macao@redhat.com> --------- Signed-off-by: Max Cao <macao@redhat.com>
First commit reverts the ci job that exercises karpenter core e2e tests from a hypershift autonode environment that was introduced in #62456
As of now, running this test does not work because our downstream was rebased to a point at which the test functionality is not compatible. The current tests in there were not testing anything the current HCP native tests are not already testing, so it makes sense to remove it altogether.
Additionally, the split-client bifurcation and API namespacing work for karpenter will leave a lot of the current test setup for this particular job to have to be reworked.
Once the karpenter core downstream get's rebased to a more up to date version with a lot more comprehensive suites and compatibility, it will make sense to come back and re-enable this.
This JIRA card track the re-enablement: https://issues.redhat.com/browse/AUTOSCALE-166
Second commit adds a new hypershift job to the ci job suite which does the same thing as
e2e-aws-techpreviewexcept it focuses on theTestKarpentertest. We need this for now in order to cut time and cost when re-running the test on PRs, rather than retrying the entire techpreview suite.