Skip to content

NO-JIRA: HCP AutoNode e2e test changes - #68109

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
maxcao13:adjust-core-e2e
Aug 14, 2025
Merged

NO-JIRA: HCP AutoNode e2e test changes#68109
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
maxcao13:adjust-core-e2e

Conversation

@maxcao13

@maxcao13 maxcao13 commented Aug 13, 2025

Copy link
Copy Markdown
Member

First commit reverts the ci job that exercises karpenter core e2e tests from a hypershift autonode environment that was introduced in #62456

As of now, running this test does not work because our downstream was rebased to a point at which the test functionality is not compatible. The current tests in there were not testing anything the current HCP native tests are not already testing, so it makes sense to remove it altogether.

Additionally, the split-client bifurcation and API namespacing work for karpenter will leave a lot of the current test setup for this particular job to have to be reworked.

Once the karpenter core downstream get's rebased to a more up to date version with a lot more comprehensive suites and compatibility, it will make sense to come back and re-enable this.

This JIRA card track the re-enablement: https://issues.redhat.com/browse/AUTOSCALE-166


Second commit adds a new hypershift job to the ci job suite which does the same thing as e2e-aws-techpreview except it focuses on the TestKarpenter test. We need this for now in order to cut time and cost when re-running the test on PRs, rather than retrying the entire techpreview suite.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 13, 2025
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@maxcao13: This pull request explicitly references no jira issue.

Details

In response to this:

  1. First commit adjusts the number of pod replicas in a downstream test suite that we reference in the test. We need to do this in order to run the tests safely on our CI system, otherwise the test will probably provision a lot of nodes that we don't want.
  2. Second commit adds a new hypershift job to the ci job suite which does the same thing as e2e-aws-tech-preview except it focuses on the TestKarpenter test. We need this for now in order to cut time and cost when re-running the test on PRs, rather than retrying the entire techpreview suite.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from csrwng and sjenning August 13, 2025 19:47
@maxcao13

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-autonode pull-ci-openshift-hypershift-main-e2e-aws-karpenter-core

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-autonode pull-ci-openshift-hypershift-main-e2e-aws-karpenter-core

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Reverts the hcp karpenter-core e2e tests and removes it.
As of now, running this test does not work because our downstream was rebased to a point at which the test functionality is not compatible.
Since the tests were not testing anything the current HCP native tests are not already testing, it makes sense to remove it altogether.
Once the karpenter core downstream get's rebased to a more up to date version with a lot more comprehensive suites and compatibility, it
will make sense to come back and re-enable this.

Additionally, the split-client bifurcation and API namespacing work for karpenter will leave a lot of the current test setup for this particular
job to have to be reworked.

Signed-off-by: Max Cao <macao@redhat.com>
@maxcao13 maxcao13 changed the title NO-JIRA: HCP AutoNode e2e test improvements NO-JIRA: HCP AutoNode e2e test changes Aug 14, 2025
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@maxcao13, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: error unmarshalling /var/tmp/gitrepo104799695/ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml: error converting YAML to JSON: yaml: line 231: could not find expected ':'
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@maxcao13: This pull request explicitly references no jira issue.

Details

In response to this:

First commit reverts the ci job that exercises karpenter core e2e tests from a hypershift autonode environment that was introduced in #62456

As of now, running this test does not work because our downstream was rebased to a point at which the test functionality is not compatible. The current tests in there were not testing anything the current HCP native tests are not already testing, so it makes sense to remove it altogether.

Additionally, the split-client bifurcation and API namespacing work for karpenter will leave a lot of the current test setup for this particular job to have to be reworked.

Once the karpenter core downstream get's rebased to a more up to date version with a lot more comprehensive suites and compatibility, it will make sense to come back and re-enable this.


Second commit adds a new hypershift job to the ci job suite which does the same thing as e2e-aws-techpreview except it focuses on the TestKarpenter test. We need this for now in order to cut time and cost when re-running the test on PRs, rather than retrying the entire techpreview suite.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Adding a ci job that only exercises the karpenter specific test to reduce time and cost when running/re-running.

Signed-off-by: Max Cao <macao@redhat.com>
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@maxcao13: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-aws-autonode openshift/hypershift presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@maxcao13: This pull request explicitly references no jira issue.

Details

In response to this:

First commit reverts the ci job that exercises karpenter core e2e tests from a hypershift autonode environment that was introduced in #62456

As of now, running this test does not work because our downstream was rebased to a point at which the test functionality is not compatible. The current tests in there were not testing anything the current HCP native tests are not already testing, so it makes sense to remove it altogether.

Additionally, the split-client bifurcation and API namespacing work for karpenter will leave a lot of the current test setup for this particular job to have to be reworked.

Once the karpenter core downstream get's rebased to a more up to date version with a lot more comprehensive suites and compatibility, it will make sense to come back and re-enable this.

This JIRA card track the re-enablement: https://issues.redhat.com/browse/AUTOSCALE-166


Second commit adds a new hypershift job to the ci job suite which does the same thing as e2e-aws-techpreview except it focuses on the TestKarpenter test. We need this for now in order to cut time and cost when re-running the test on PRs, rather than retrying the entire techpreview suite.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jkyros

jkyros commented Aug 14, 2025

Copy link
Copy Markdown
Member

Thanks Max, this should make the red go away while we get our house in order. And hey, you put it in, they should let you take it back out, right? 😄
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
@muraee

muraee commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkyros, maxcao13, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2025
@maxcao13

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 14, 2025
@openshift-ci

openshift-ci Bot commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

@maxcao13: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/hypershift/main/e2e-aws-karpenter-core 57d57e0 link unknown /pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-karpenter-core

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 189456f into openshift:master Aug 14, 2025
15 checks passed
@maxcao13
maxcao13 deleted the adjust-core-e2e branch August 14, 2025 14:36
JslYoon pushed a commit to JslYoon/openshift-release that referenced this pull request Aug 25, 2025
* autonode: revert hcp karpenter e2e core test

Reverts the hcp karpenter-core e2e tests and removes it.
As of now, running this test does not work because our downstream was rebased to a point at which the test functionality is not compatible.
Since the tests were not testing anything the current HCP native tests are not already testing, it makes sense to remove it altogether.
Once the karpenter core downstream get's rebased to a more up to date version with a lot more comprehensive suites and compatibility, it
will make sense to come back and re-enable this.

Additionally, the split-client bifurcation and API namespacing work for karpenter will leave a lot of the current test setup for this particular
job to have to be reworked.

Signed-off-by: Max Cao <macao@redhat.com>

* autonode: add optional autonode/karpenter specific test to hcp suite

Adding a ci job that only exercises the karpenter specific test to reduce time and cost when running/re-running.

Signed-off-by: Max Cao <macao@redhat.com>

---------

Signed-off-by: Max Cao <macao@redhat.com>
etmurasaki pushed a commit to etmurasaki/release that referenced this pull request Sep 3, 2025
* autonode: revert hcp karpenter e2e core test

Reverts the hcp karpenter-core e2e tests and removes it.
As of now, running this test does not work because our downstream was rebased to a point at which the test functionality is not compatible.
Since the tests were not testing anything the current HCP native tests are not already testing, it makes sense to remove it altogether.
Once the karpenter core downstream get's rebased to a more up to date version with a lot more comprehensive suites and compatibility, it
will make sense to come back and re-enable this.

Additionally, the split-client bifurcation and API namespacing work for karpenter will leave a lot of the current test setup for this particular
job to have to be reworked.

Signed-off-by: Max Cao <macao@redhat.com>

* autonode: add optional autonode/karpenter specific test to hcp suite

Adding a ci job that only exercises the karpenter specific test to reduce time and cost when running/re-running.

Signed-off-by: Max Cao <macao@redhat.com>

---------

Signed-off-by: Max Cao <macao@redhat.com>
xiaojiey pushed a commit to xiaojiey/release that referenced this pull request Sep 9, 2025
* autonode: revert hcp karpenter e2e core test

Reverts the hcp karpenter-core e2e tests and removes it.
As of now, running this test does not work because our downstream was rebased to a point at which the test functionality is not compatible.
Since the tests were not testing anything the current HCP native tests are not already testing, it makes sense to remove it altogether.
Once the karpenter core downstream get's rebased to a more up to date version with a lot more comprehensive suites and compatibility, it
will make sense to come back and re-enable this.

Additionally, the split-client bifurcation and API namespacing work for karpenter will leave a lot of the current test setup for this particular
job to have to be reworked.

Signed-off-by: Max Cao <macao@redhat.com>

* autonode: add optional autonode/karpenter specific test to hcp suite

Adding a ci job that only exercises the karpenter specific test to reduce time and cost when running/re-running.

Signed-off-by: Max Cao <macao@redhat.com>

---------

Signed-off-by: Max Cao <macao@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants