Skip to content

SDN-4168: Fix for nmstate deployment related failures - #29452

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
pperiyasamy:fix-nmstate-failures
Jan 24, 2025
Merged

SDN-4168: Fix for nmstate deployment related failures#29452
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
pperiyasamy:fix-nmstate-failures

Conversation

@pperiyasamy

@pperiyasamy pperiyasamy commented Jan 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This PR fixes recent test failures around nmstate deployment seen from CI runs.

  1. [sig-auth] all workloads in ns/openshift-nmstate must set the 'openshift.io/required-scc' annotation

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29437/pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial/1879584910717489152

  1. Wait enough to get nmstate-handler daemonset running state.
[sig-network][Feature:IPsec] when using openshift ovn-kubernetes [BeforeAll] check traffic [apigroup:config.openshift.io] [Suite:openshift/network/ipsec] with IPsec in full mode
  [BeforeAll] github.com/openshift/origin/test/extended/networking/ipsec.go:449
  [It] github.com/openshift/origin/test/extended/networking/ipsec.go:628

  [FAILED] Unexpected error:
      <*errors.errorString | 0xc0015847e0>:
      failed to get nmstate handler running: context deadline exceeded
      {
          s: "failed to get nmstate handler running: context deadline exceeded",
      }
  occurred
  In [BeforeAll] at: github.com/openshift/origin/test/extended/networking/ipsec.go:464 @ 01/16/25 11:12:58.598

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-cluster-network-operator-2606-openshift-origin-29437-e2e-aws-ovn-ipsec-serial/1879821657376296960

@pperiyasamy
Fix for nmstate deployment related issues
e2e54ef 
This commit fixes following test failures seen in CI runs.

1. [sig-auth] all workloads in ns/openshift-nmstate must set the 'openshift.io/required-scc' annotation

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29437/pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial/1879584910717489152

2. Wait enough to get nmstate-handler daemonset running state.

[sig-network][Feature:IPsec] when using openshift ovn-kubernetes [BeforeAll] check traffic [apigroup:config.openshift.io] [Suite:openshift/network/ipsec] with IPsec in full mode
  [BeforeAll] github.com/openshift/origin/test/extended/networking/ipsec.go:449
  [It] github.com/openshift/origin/test/extended/networking/ipsec.go:628

  [FAILED] Unexpected error:
      <*errors.errorString | 0xc0015847e0>:
      failed to get nmstate handler running: context deadline exceeded
      {
          s: "failed to get nmstate handler running: context deadline exceeded",
      }
  occurred
  In [BeforeAll] at: github.com/openshift/origin/test/extended/networking/ipsec.go:464 @ 01/16/25 11:12:58.598

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-cluster-network-operator-2606-openshift-origin-29437-e2e-aws-ovn-ipsec-serial/1879821657376296960

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
@openshift-ci
openshift-ci Bot requested review from knobunc and p0lyn0mial January 20, 2025 11:15
@pperiyasamy

pperiyasamy commented Jan 20, 2025

Copy link
Copy Markdown
Member Author

/assign @dgoodwin @deads2k @jcaamano

@dgoodwin

dgoodwin commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@dgoodwin

dgoodwin commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@openshift-ci

openshift-ci Bot commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pperiyasamy

pperiyasamy commented Jan 20, 2025

Copy link
Copy Markdown
Member Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 20, 2025
@pperiyasamy pperiyasamy changed the title Fix for nmstate deployment related failures SDN-4168: Fix for nmstate deployment related failures Jan 20, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2025
@openshift-ci-robot

openshift-ci-robot commented Jan 20, 2025 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@pperiyasamy: This pull request references SDN-4168 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This PR fixes recent test failures around nmstate deployment seen from CI runs.

  1. [sig-auth] all workloads in ns/openshift-nmstate must set the 'openshift.io/required-scc' annotation

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29437/pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial/1879584910717489152

  1. Wait enough to get nmstate-handler daemonset running state.
[sig-network][Feature:IPsec] when using openshift ovn-kubernetes [BeforeAll] check traffic [apigroup:config.openshift.io] [Suite:openshift/network/ipsec] with IPsec in full mode
 [BeforeAll] github.com/openshift/origin/test/extended/networking/ipsec.go:449
 [It] github.com/openshift/origin/test/extended/networking/ipsec.go:628

 [FAILED] Unexpected error:
     <*errors.errorString | 0xc0015847e0>:
     failed to get nmstate handler running: context deadline exceeded
     {
         s: "failed to get nmstate handler running: context deadline exceeded",
     }
 occurred
 In [BeforeAll] at: github.com/openshift/origin/test/extended/networking/ipsec.go:464 @ 01/16/25 11:12:58.598

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-cluster-network-operator-2606-openshift-origin-29437-e2e-aws-ovn-ipsec-serial/1879821657376296960

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot

openshift-ci-robot commented Jan 20, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 0f2d600 and 2 for PR HEAD e2e54ef in total

@openshift-ci-robot

openshift-ci-robot commented Jan 20, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 4c63717 and 1 for PR HEAD e2e54ef in total

@openshift-ci-robot

openshift-ci-robot commented Jan 21, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 58ddec8 and 0 for PR HEAD e2e54ef in total

@openshift-ci-robot

openshift-ci-robot commented Jan 21, 2025

Copy link
Copy Markdown

/hold

Revision e2e54ef was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025
@pperiyasamy

pperiyasamy commented Jan 22, 2025

Copy link
Copy Markdown
Member Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
@pperiyasamy

pperiyasamy commented Jan 22, 2025

Copy link
Copy Markdown
Member Author

/retest-required

@openshift-ci-robot

openshift-ci-robot commented Jan 22, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 4b05413 and 2 for PR HEAD e2e54ef in total

@openshift-ci-robot

openshift-ci-robot commented Jan 23, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 4ca8255 and 2 for PR HEAD e2e54ef in total

1 similar comment
@openshift-ci-robot

openshift-ci-robot commented Jan 23, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 4ca8255 and 2 for PR HEAD e2e54ef in total

@openshift-ci

openshift-ci Bot commented Jan 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@pperiyasamy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn e2e54ef link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-single-node-serial e2e54ef link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade e2e54ef link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade e2e54ef link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node e2e54ef link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt

openshift-trt Bot commented Jan 23, 2025

Copy link
Copy Markdown

Job Failure Risk Analysis for sha: e2e54ef

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-serial Medium
[sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial]
This test has passed 96.46% of 424 runs on release 4.19 [Overall] in the last week.

@dgoodwin

dgoodwin commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-aws-ovn-serial

Known issue outside pr

@openshift-ci

openshift-ci Bot commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-aws-ovn-serial

Details

In response to this:

/override ci/prow/e2e-aws-ovn-serial

Known issue outside pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 5312142 into openshift:master Jan 24, 2025
@pperiyasamy pperiyasamy mentioned this pull request Apr 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knobunc knobunc Awaiting requested review from knobunc
@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

@dgoodwin dgoodwin

@deads2k deads2k

@jcaamano jcaamano

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pperiyasamy @dgoodwin @openshift-ci-robot @deads2k @jcaamano