Skip to content

OpenShift only: add skips for unsupported cases - #295

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
oribon:evpnskip
Aug 9, 2026
Merged

OpenShift only: add skips for unsupported cases#295
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
oribon:evpnskip

Conversation

@oribon

@oribon oribon commented Aug 9, 2026

Copy link
Copy Markdown

needed for openshift/frr#135

Summary by CodeRabbit

  • Tests
    • Temporarily skipped EVPN-related end-to-end tests.
    • Temporarily skipped AllowAsIn end-to-end tests.

Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
@openshift-ci
openshift-ci Bot requested review from dougbtv and fedepaol August 9, 2026 06:01
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2026
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dbf18ed5-3566-45aa-86d3-fc49a36bd870

📥 Commits

Reviewing files that changed from the base of the PR and between 10222d7 and 80d719e.

📒 Files selected for processing (1)
  • openshift-ci/run_frrk8s_e2e.sh

Walkthrough

The FRR Kubernetes end-to-end test runner now skips EVPN-related tests and tests involving AllowAsIn.

Changes

FRR Kubernetes E2E test selection

Layer / File(s) Summary
Add temporary test skips
openshift-ci/run_frrk8s_e2e.sh
The runner adds skip patterns for EVPN tests and tests involving AllowAsIn.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: fedepaol

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only references a linked FRR pull request and omits the required kind, purpose, reviewer notes, and release note sections. Complete the required template sections, including the PR kind, change rationale, reviewer notes, and release note or NONE.
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the OpenShift-specific skips added for unsupported test cases.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only two static SKIP regex assignments; the added lines contain no Ginkgo It, Describe, Context, or When test titles or dynamic title values.
Test Structure And Quality ✅ Passed The PR changes only the shell runner; it adds no Ginkgo It, setup, cleanup, wait, or assertion code, so this Ginkgo quality check is not applicable.
Microshift Test Compatibility ✅ Passed The patch changes only openshift-ci/run_frrk8s_e2e.sh by adding skip patterns; it adds no Ginkgo tests or unavailable API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only an existing shell runner by adding EVPN and AllowAsIn skip patterns; it adds no Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only four skip-pattern lines in an E2E shell runner; it adds no manifests, controllers, operators, replicas, affinities, node selectors, tolerations, or other scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only two SKIP assignments in a shell runner. It adds no OTE process-level stdout writes; the suite logger already targets GinkgoWriter.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit adds only two SKIP regex entries in the shell runner; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto ✅ Passed The four added lines only extend the Ginkgo skip regex for EVPN and AllowAsIn; no weak-crypto algorithms, crypto code, or secret comparisons were added.
Container-Privileges ✅ Passed The PR adds only EVPN and AllowAsIn skip rules; no added privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation setting exists. The host-network environment line is uncha...
No-Sensitive-Data-In-Logs ✅ Passed The patch only adds static EVPN and AllowAsIn skip patterns. The existing SKIP log prints test names, not passwords, tokens, PII, hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 9, 2026

Copy link
Copy Markdown

@oribon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SchSeba SchSeba left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2026
@openshift-ci

openshift-ci Bot commented Aug 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oribon, SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oribon

oribon commented Aug 9, 2026

Copy link
Copy Markdown
Author

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 9, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@oribon: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit d9216bd into openshift:main Aug 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants