AGENT-1570: Remove all NoRegistryClusterInstall feature gate check

[pawanpinjarkar]

The InternalReleaseImage(IRI) functionality will now be always active instead of being gated behind a feature flag

- What I did
Remove all NoRegistryClusterInstall feature gate check

- How to verify it

/test e2e-agent-compact-ipv4-iso-no-registry

- Description for the changelog

Summary by CodeRabbit

• New Features

  • Internal Release Image management is now enabled by default.
  • Internal Release Image resources, certificates, credentials, bootstrap configuration, and deletion safeguards are processed whenever the resource is present.
  • Related controllers and informers now start automatically, providing more consistent cluster setup and resource management.

• Tests

  • Updated unit and end-to-end coverage to reflect always-on Internal Release Image functionality.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@pawanpinjarkar: This pull request references AGENT-1570 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

The InternalReleaseImage(IRI) functionality will now be always active instead of being gated behind a feature flag

- What I did
Remove all NoRegistryClusterInstall feature gate check

- How to verify it

/test e2e-agent-compact-ipv4-iso-no-registry

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pawanpinjarkar]

/test e2e-agent-compact-ipv4-iso-no-registry

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 981b1984-cee1-40a9-9c52-b516b384e90d

📥 Commits

Reviewing files that changed from the base of the PR and between fb5fb69 and 45f44ac.

📒 Files selected for processing (4)

• cmd/machine-config-controller/start.go
• pkg/controller/template/template_controller.go
• pkg/controller/template/template_controller_test.go
• test/e2e-bootstrap/bootstrap_test.go

💤 Files with no reviewable changes (3)

• test/e2e-bootstrap/bootstrap_test.go
• cmd/machine-config-controller/start.go
• pkg/controller/template/template_controller.go

---

Walkthrough

InternalReleaseImage controllers, informers, bootstrap generation, certificate reconciliation, secret merging, policy deployment, and tests no longer depend on the NoRegistryClusterInstall feature gate.

Changes

InternalReleaseImage processing

Layer / File(s)	Summary
Unconditional controller and informer startup cmd/machine-config-controller/start.go, cmd/machine-config-daemon/start.go, cmd/machine-config-operator/start.go	InternalReleaseImage controllers and informers now start unconditionally. Template and operator wiring uses direct informer references.
Resource-driven InternalReleaseImage processing pkg/controller/bootstrap/bootstrap.go, pkg/controller/certrotation/*, pkg/controller/common/iri_secret_merger.go, pkg/controller/template/template_controller.go, pkg/operator/sync.go	Bootstrap generation, certificate reconciliation, secret merging, and deletion-guard policy deployment now use InternalReleaseImage resource availability.
Feature-gate-independent validation pkg/controller/certrotation/certrotation_controller_test.go, pkg/controller/common/iri_secret_merger_test.go, pkg/controller/template/template_controller_test.go, test/e2e-iri/main_test.go, test/e2e-bootstrap/bootstrap_test.go	Tests remove obsolete feature-gate setup and end-to-end skip behavior. Template controller callers use the reduced constructor.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: pablintino, bfournie

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 errors, 1 warning)

Check name	Status	Explanation	Resolution
No-Weak-Crypto	❌ Error	Removing the feature-gate guard activates pullSecretHasAuth for IRI manifests; it compares base64 user:password credentials with Go ==, which is non-constant-time.	Compare the credential bytes with crypto/subtle.ConstantTimeCompare or hmac.Equal before using the result.
No-Sensitive-Data-In-Logs	❌ Error	The PR passes the Secrets informer unconditionally; template handlers log each Secret with %v, and Secret.String includes Data, which can expose passwords, tokens, and customer data.	Replace full Secret logging with non-sensitive metadata such as namespace and name. Do not log Secret.Data or StringData.
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the removal of all NoRegistryClusterInstall feature-gate checks, which is the main change.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR adds or changes no Ginkgo test titles. Its changed tests only remove cases or adjust setup; existing Go subtest names remain static table labels.
Test Structure And Quality	✅ Passed	The PR changes no Ginkgo specs: changed tests use Go testing/testify, fake clients, or remove gating and setup. No new cluster resource creation, Eventually/Consistently wait, or assertion lacking...
Microshift Test Compatibility	✅ Passed	The diff adds no Ginkgo e2e tests; it only updates existing Go test wiring, so the MicroShift API compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR adds no Ginkgo e2e tests. Its e2e change only removes a feature-gate TestMain skip, and existing IRI tests use standard func Test declarations.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only Go code and tests. It adds no affinity, spread, replica, node selector, toleration, or PDB constraints; existing deployment manifests are unchanged.
Ote Binary Stdout Contract	✅ Passed	The OTE command and extension suites are unchanged; the PR adds no process-level stdout writes and removes only a TestMain stderr write.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR adds no Ginkgo e2e tests or test declarations. It only removes feature-gate setup and changes unit-test fixtures, so this check's IPv4 and connectivity conditions do not apply.
Container-Privileges	✅ Passed	The PR changes only Go and test files. The merge-base diff adds no manifest paths or privilege settings such as privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pawanpinjarkar
Once this PR has been reviewed and has the lgtm label, please assign ptalgulk01 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pawanpinjarkar]

/test e2e-agent-compact-ipv4-iso-no-registry

[openshift-ci]

@pawanpinjarkar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/perfscale-control-plane-6nodes	0288ae6	link	false	/test perfscale-control-plane-6nodes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.