Skip to content

[release-4.18] OCPBUGS-54462: OSUpdateStarted event should only be emitted on actual OS updates - #4967

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.18from
openshift-cherrypick-robot:cherry-pick-4864-to-release-4.18
Apr 2, 2025
Merged

[release-4.18] OCPBUGS-54462: OSUpdateStarted event should only be emitted on actual OS updates#4967
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.18from
openshift-cherrypick-robot:cherry-pick-4864-to-release-4.18

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 1, 2025

Copy link
Copy Markdown

This is an automated cherry-pick of #4864

/assign pperiyasamy

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 1, 2025
Merged
@openshift-ci-robot

openshift-ci-robot commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-51009 has been cloned as Jira Issue OCPBUGS-54462. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-54462: OSUpdateStarted event should only be emitted on actual OS updates

Details

In response to this:

This is an automated cherry-pick of #4864

/assign pperiyasamy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.18] OCPBUGS-51009: OSUpdateStarted event should only be emitted on actual OS updates [release-4.18] OCPBUGS-54462: OSUpdateStarted event should only be emitted on actual OS updates Apr 1, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 1, 2025
@openshift-ci-robot

openshift-ci-robot commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-54462, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-51009 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-51009 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #4864

/assign pperiyasamy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested a review from sergiordlr April 1, 2025 12:42
@pperiyasamy

pperiyasamy commented Apr 1, 2025

Copy link
Copy Markdown
Member

/assign @djoshy @yuqi-zhang

@pperiyasamy pperiyasamy mentioned this pull request Apr 1, 2025
Closed
@openshift-ci

openshift-ci Bot commented Apr 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview 62f36dd link false /test e2e-gcp-op-techpreview
ci/prow/e2e-vsphere-ovn-upi-zones 62f36dd link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-vsphere-ovn-upi 62f36dd link false /test e2e-vsphere-ovn-upi
ci/prow/e2e-vsphere-ovn-zones 62f36dd link false /test e2e-vsphere-ovn-zones
ci/prow/e2e-azure-ovn-upgrade-out-of-change 62f36dd link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ptalgulk01

ptalgulk01 commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 2, 2025
@djoshy

djoshy commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

/lgtm

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 2, 2025
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2025
@openshift-ci

openshift-ci Bot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2025
@openshift-ci-robot

openshift-ci-robot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 28740b6 and 2 for PR HEAD 62f36dd in total

@openshift-merge-bot
openshift-merge-bot Bot merged commit 85ff8f1 into openshift:release-4.18 Apr 2, 2025
@openshift-ci-robot

openshift-ci-robot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-54462: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-54462 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #4864

/assign pperiyasamy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot

openshift-bot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.18.0-202504021503.p0.g85ff8f1.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergiordlr sergiordlr Awaiting requested review from sergiordlr
@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi
@RishabhSaini RishabhSaini Awaiting requested review from RishabhSaini

Assignees

@rbbratta rbbratta

@eurijon eurijon

@djoshy djoshy

@yuqi-zhang yuqi-zhang

@pperiyasamy pperiyasamy

@anuragthehatter anuragthehatter

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.