CNTRLPLANE-4038: feat(supportedversion): bump latest supported OCP version to 5.1 - #9288
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@Nirshal: This pull request references CNTRLPLANE-4038 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
area/control-plane-operator
db76c97 to
2d0989f
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe latest supported OpenShift version changes from 5.0.0 to 5.1.0. Kubernetes mappings now include OpenShift 5.0 to Kubernetes 1.36 and OpenShift 5.1 to Kubernetes 1.37. Direct major/minor lookups preserve separate OpenShift 5.x mappings. Tests and E2E utilities include OpenShift 5.1.0. Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.github.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/e2e/util/version.go (1)
38-38: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove the redundant
init()block.
semver.MustParsevalidates each package-level version during package initialization. The_ = Version51assignments do not provide a compile-time check. Remove these assignments and theinit()block.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e/util/version.go` at line 38, Remove the redundant init() block and its _ = Version51-style assignments in the version definitions, leaving semver.MustParse package-level initialization as the sole validation mechanism.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/e2e/util/version.go`:
- Line 38: Remove the redundant init() block and its _ = Version51-style
assignments in the version definitions, leaving semver.MustParse package-level
initialization as the sole validation mechanism.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 63c58805-b31f-4379-96f3-2bb86517e56f
📒 Files selected for processing (3)
support/supportedversion/version.gosupport/supportedversion/version_test.gotest/e2e/util/version.go
This |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9288 +/- ##
==========================================
+ Coverage 45.68% 45.69% +0.01%
==========================================
Files 781 781
Lines 97730 97732 +2
==========================================
+ Hits 44646 44659 +13
+ Misses 50015 50005 -10
+ Partials 3069 3068 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| "4.21.0": semver.MustParse("1.34.0"), | ||
| "4.22.0": semver.MustParse("1.35.0"), | ||
| "4.23.0": semver.MustParse("1.36.0"), | ||
| "4.24.0": semver.MustParse("1.37.0"), |
2d0989f to
d3ae99c
Compare
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
d3ae99c to
a309ad9
Compare
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
a309ad9 to
5836d27
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, Nirshal The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Update LatestSupportedVersion from 5.0 to 5.1 to unblock 5.1 nightly payload acceptance and the Azure AKS conformance periodic job on the release-5.1 branch. - Bump LatestSupportedVersion to 5.1.0 - Add 5.0.0 and 5.1.0 entries to ocpVersionToKubeVersion map with direct lookup (5.1+ are distinct versions with no 4.x equivalent) - Remove normalizeToV4 from GetKubeVersionForSupportedVersion since the map now uses real version keys for both 4.x and 5.x series - Add Version51 e2e constant with compile-time check - Update test expectations for the new supported versions list Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5836d27 to
072f8e0
Compare
|
/lgtm |
|
Scheduling tests matching the |
Test Resultse2e-aws
e2e-aks
|
|
/retest |
|
/retest-required |
|
/retest AI-generated. Review for accuracy. |
|
@Nirshal: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override "Red Hat Konflux / hypershift-operator-enterprise-contract / hypershift-operator-main" We know these are failing outside this PR. Someone is working on a fix for them. No need to hold this PR for them. |
|
/verified by e2e & UTs |
|
@bryan-cox: Overrode contexts on behalf of bryan-cox: Red Hat Konflux / hypershift-operator-enterprise-contract / hypershift-operator-main, Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci-robot
added
the
verified
|
@bryan-cox: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
aaaf8af
into
openshift:main
7 participants
What this PR does / why we need it:
Bumps
LatestSupportedVersionfrom 5.0 to 5.1 to unblock 5.1 nightly payload acceptance and the Azure AKS conformance periodic job (e2e-azure-aks-ovn-conformance) on therelease-5.1branch.The HyperShift operator's
supported-versionsConfigMap only listed up to 5.0, causing all 5.1 nightly payload runs to fail because NodePool rejects the 5.1 payload as unsupported.Changes:
LatestSupportedVersionto5.1.04.24(5.1 normalized) to Kubernetes1.37version mappingVersion51e2e constant with compile-time checkWhich issue(s) this PR fixes:
Fixes CNTRLPLANE-4038
Previous version bump for reference: CNTRLPLANE-1370 / PR #6739
Slack thread flagging the issue: link
Checklist
Summary by CodeRabbit
New Features
Bug Fixes