AUTOSCALE-166: feat(karpenter): deploy NodeOverlay CRD to guest cluster

[fishereskew]

What this PR does / why we need it:

Adds the NodeOverlay CRD (karpenter.sh_nodeoverlays.yaml) to the hypershift karpenter controller so it gets deployed to guest clusters alongside EC2NodeClass, NodePool, and NodeClaim.

The upstream karpenter core regression e2e tests expect the NodeOverlay CRD to exist in the cluster. Without this, tests fail with no matches for kind "NodeOverlay".

Which issue(s) this PR fixes:

A part of AUTOSCALE-166

Special notes for your reviewer:

The standalone karpenter-operator repo already has NodeOverlay wired up via CoreCRDs in pkg/assets/assets.go.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Summary by CodeRabbit

• New Features

  • Added support for managing and reconciling NodeOverlay custom resources.

• Tests

  • Expanded reconciliation coverage to verify NodeOverlay resources are handled correctly.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@fishereskew: This pull request references AUTOSCALE-166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Adds the NodeOverlay CRD (karpenter.sh_nodeoverlays.yaml) to the hypershift karpenter controller so it gets deployed to guest clusters alongside EC2NodeClass, NodePool, and NodeClaim.

The upstream karpenter core regression e2e tests expect the NodeOverlay CRD to exist in the cluster. Without this, tests fail with no matches for kind "NodeOverlay".

Which issue(s) this PR fixes:

A part of AUTOSCALE-166

Special notes for your reviewer:

The standalone karpenter-operator repo already has NodeOverlay wired up via CoreCRDs in pkg/assets/assets.go.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

The Karpenter controller now manages the NodeOverlay CRD. It includes the CRD in its definitions, watches nodeoverlays.karpenter.sh, and reconciles create and update operations. The concurrent CRD reconciliation test now includes crdNodeOverlay in setup, snapshots, and integrity checks.

Suggested reviewers: enxebre, maxcao13

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the deployment of the NodeOverlay CRD to the guest cluster, which is the main change.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR adds no Ginkgo or subtest titles. Its test changes only add crdNodeOverlay references; existing titles use static descriptive text.
Test Structure And Quality	✅ Passed	The change extends one synchronous fake-client concurrency test; its assertions have diagnostic messages, and it adds no cluster waits or real resources requiring cleanup.
Topology-Aware Scheduling Compatibility	✅ Passed	The patch only adds NodeOverlay CRD registration, watching, reconciliation, and test coverage. It adds no pod affinity, topology spread, replicas, selectors, tolerations, or PDB constraints.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR adds no new Ginkgo e2e tests; it only updates CRD controller code and an existing standard Go unit test, with no IPv4 or external-connectivity assumptions.
No-Weak-Crypto	✅ Passed	The commit adds only NodeOverlay CRD registration, watch filtering, reconciliation, and test fixtures; no weak crypto, custom crypto, or secret comparison was added.
Container-Privileges	✅ Passed	The commit changes only Go controller and test files; no added or changed content contains privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds only NodeOverlay CRD wiring and test coverage; it introduces no logging statements or sensitive values in log fields.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fishereskew
Once this PR has been reviewed and has the lgtm label, please assign muraee for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

🧹 Nitpick comments (1)

karpenter-operator/controllers/karpenter/karpenter_controller.go (1)

100-101: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Add deterministic coverage for the nodeoverlays.karpenter.sh CRD watch.

The *TestReconcileCRDsConcurrentAccess case validates global CRD spec concurrency, but no test checks that a nodeoverlays.karpenter.sh event enqueues the expected controller request. Add coverage for this new case, or use crdNodeOverlay.Name in the case so the watch filter cannot drift from the loaded manifest.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@karpenter-operator/controllers/karpenter/karpenter_controller.go` around
lines 100 - 101, Add deterministic coverage to TestReconcileCRDsConcurrentAccess
confirming that a nodeoverlays.karpenter.sh event enqueues the expected
controller request, or replace the literal watch case with crdNodeOverlay.Name
so it remains aligned with the loaded manifest. Keep existing CRD watch behavior
unchanged.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@karpenter-operator/controllers/karpenter/karpenter_controller.go`:
- Around line 100-101: Add deterministic coverage to
TestReconcileCRDsConcurrentAccess confirming that a nodeoverlays.karpenter.sh
event enqueues the expected controller request, or replace the literal watch
case with crdNodeOverlay.Name so it remains aligned with the loaded manifest.
Keep existing CRD watch behavior unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: c2c639ce-a8ce-4a47-81ed-7aeeced93b55

📥 Commits

Reviewing files that changed from the base of the PR and between d24cfb2 and e208788.

📒 Files selected for processing (2)

• karpenter-operator/controllers/karpenter/karpenter_controller.go
• karpenter-operator/controllers/karpenter/karpenter_controller_test.go

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.02%. Comparing base (9e00898) to head (e208788).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...ator/controllers/karpenter/karpenter_controller.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9262   +/-   ##
=======================================
  Coverage   45.02%   45.02%           
=======================================
  Files         778      778           
  Lines       97539    97540    +1     
=======================================
+ Hits        43918    43919    +1     
  Misses      50592    50592           
  Partials     3029     3029           

Files with missing lines	Coverage Δ
...ator/controllers/karpenter/karpenter_controller.go	30.02% <50.00%> (+0.17%)	⬆️

Flag	Coverage Δ
cmd-support	38.77% <ø> (ø)
cpo-hostedcontrolplane	47.24% <ø> (ø)
cpo-other	45.79% <ø> (ø)
hypershift-operator	55.00% <ø> (ø)
other	34.33% <50.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fishereskew]

/area karpenter-operator