feat(gcp): add GCP PSC conditions to metrics and platform-specific gauges

[apahim]

Summary

Implements GCP-959 (GA checklist items 6.1, 6.2, 6.3): add PSC connectivity conditions to failure metrics and transition duration histograms, and expose a GCP credential validity gauge.

Changes

1. GCP GetCredentialStatus foundation (gcp.go)

• Add CredentialStatus type (Valid=0, Invalid=1, Unknown=2) mirroring the AWS pattern
• Add GetCredentialStatus() inspecting ValidGCPWorkloadIdentity and ValidGCPCredentials conditions

2. PSC conditions in ExpectedHCConditions() (support/conditions/conditions.go)

• Add GCPEndpointAvailable and GCPServiceAttachmentAvailable to the GCP case unconditionally
• Unlike AWS, GCP has no Public-only endpoint access mode — both GCP modes use PSC, so no gate is needed
• Impact: PSC failures now appear in hypershift_hostedclusters_failure_conditions

3. PSC conditions in transition duration metrics (metrics.go)

• Add GCPEndpointAvailable and GCPServiceAttachmentAvailable to collectTransitionDurationMetrics()
• Impact: PSC setup latency tracked in hypershift_hosted_cluster_transition_seconds histogram

4. hypershift_cluster_invalid_gcp_creds gauge (metrics.go)

• Add metric constant, descriptor, collectGcpCredsMetric() function
• Called unconditionally from collectPerClusterMetrics() — non-GCP clusters report 2 (unknown)

Tests

• TestGetCredentialStatus — all condition combinations for the GCP tri-state function
• TestReportInvalidGcpCreds — gauge metric collection for all credential states
• TestReportTransitionDurationForGCPEndpointConditions — histogram observation for PSC conditions
• TestExpectedHCConditionsGCPPlatform — expected conditions for GCP platform

Jira: https://redhat.atlassian.net/browse/GCP-959

Summary by CodeRabbit

• New Features

  • Added GCP credential-status reporting for HostedClusters, distinguishing valid, invalid, and unknown states.
  • Added GCP credential validity metrics.
  • Added transition-duration metrics for GCP endpoint and service-attachment conditions.
  • GCP hosted clusters now report endpoint and service-attachment availability conditions.

• Bug Fixes

  • Improved handling of missing, unknown, and mixed credential conditions in status reporting.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2578d589-9620-40b8-81f8-e0557a021ab1

📥 Commits

Reviewing files that changed from the base of the PR and between 8ddee28 and 4a61331.

📒 Files selected for processing (6)

• hypershift-operator/controllers/hostedcluster/internal/platform/gcp/gcp.go
• hypershift-operator/controllers/hostedcluster/internal/platform/gcp/gcp_conditions_test.go
• hypershift-operator/controllers/hostedcluster/metrics/metrics.go
• hypershift-operator/controllers/hostedcluster/metrics/metrics_test.go
• support/conditions/conditions.go
• support/conditions/conditions_test.go

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

---

📝 Walkthrough

Walkthrough

This change adds tri-state GCP credential evaluation for HostedClusters. The metrics collector exposes credential status and tracks GCP endpoint and service-attachment condition transitions. Expected GCP conditions are marked true for GCP platforms and remain absent for AWS platforms. Tests cover credential states, metric values, transition observations, and platform-specific expected conditions.

Sequence Diagram(s)

sequenceDiagram
  participant HostedCluster
  participant MetricsCollector
  participant GCPPlatform
  participant Prometheus
  HostedCluster->>MetricsCollector: provide platform and conditions
  MetricsCollector->>GCPPlatform: GetCredentialStatus(HostedCluster)
  GCPPlatform-->>MetricsCollector: return credential status
  MetricsCollector->>Prometheus: emit GCP metrics

Loading

Possibly related PRs

• openshift/hypershift#9242: Related GCP credential-status helpers, metrics, conditions, and tests.
• openshift/hypershift#9250: Related GCP credential-status, metrics, PSC conditions, and tests.

Suggested reviewers: bryan-cox

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apahim
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment