multus: Fix typo from 'k8d' to 'k8s' in multus.yaml

[ssonigra]

There is mention of k8d instead of k8s in the code which needs to be corrected as its not a good practice to have typos in the code.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Summary by CodeRabbit

• Documentation
  • Corrected a typo in comments describing Kubernetes configuration generation for the auxiliary networking components.

Walkthrough

This change corrects two k8d to k8s comment typos in bindata/network/multus/multus.yaml. Runtime behavior is unchanged.

Changes

Multus comment corrections

Layer / File(s)	Summary
Kubernetes comment text fixes bindata/network/multus/multus.yaml	Two script comments now use k8s instead of k8d.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: miheer, taanyas

---

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

• Ignore

❌ Failed checks (3 errors)

Check name	Status	Explanation	Resolution
Commit Message Quality	❌ Error	The single commit is scoped, logical, concise, and non-merge, but its body only restates the typo and does not explain why the correction is needed.	Amend the commit body to state the rationale, such as preventing incorrect Kubernetes terminology in generated Multus configuration comments.
Unit Tests For Go Changes	❌ Error	The PR modifies bindata/network/multus/multus.yaml but includes no *_test.go changes.	Add a corresponding test file, or document the valid trivial-change justification under “How to verify it”; then use @coderabbitai ignore pre-merge checks after other checks pass.
Container-Privileges	❌ Error	multus.yaml contains hostNetwork:true, hostPID:true, and privileged:true at multiple workloads; these match the container-privileges checks.	Remove the privilege settings where possible. Otherwise document the required exception and apply the least-privilege security context.

✅ Passed checks (21 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Pr Quality	✅ Passed	The commit has a clear typo-fix title and changes only two comments from “k8d” to “k8s” in one YAML file (2 additions, 2 deletions).
E2e Tests For Feature Changes	✅ Passed	The PR changes only two YAML comments from “k8d” to “k8s”; no Go files or user-facing behavior changed, so E2E requirements do not apply.
Rbac Least Privilege	✅ Passed	The commit changes only two comments in bindata/network/multus/multus.yaml; no ClusterRole or Role rules are added or modified.
Docs For Feature And Behavior Changes	✅ Passed	The commit changes only two embedded shell comments from “k8d” to “k8s”; no commands, control flow, behavior, architecture, or docs paths changed.
Stale Project Docs And Config	✅ Passed	The PR changes only two comments in bindata/network/multus/multus.yaml, from “k8d” to “k8s”; no project docs or config become stale.
Go And Test Code Quality	✅ Passed	The parent-to-HEAD diff changes only two comments in bindata/network/multus/multus.yaml; no new or modified Go code exists to trigger the nine checks.
Ai-Generated Code Smell	✅ Passed	The patch changes only two existing comments from “k8d” to “k8s”; it adds no tests, logic, verbose code, or AI/prompt references.
Stable And Deterministic Test Names	✅ Passed	The diff changes only two comments in multus.yaml, from “k8d” to “k8s”; it adds or changes no Ginkgo test titles or dynamic test names.
Test Structure And Quality	✅ Passed	The PR changes only two comments in bindata/network/multus/multus.yaml; it adds no Ginkgo tests or cluster operations requiring this check.
Microshift Test Compatibility	✅ Passed	The patch changes only two comments in multus.yaml and adds no Ginkgo e2e tests or MicroShift-sensitive test references.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The HEAD commit changes only two YAML comments from “k8d” to “k8s”; it adds no Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only two embedded comments from “k8d” to “k8s”; it adds no scheduling constraints or topology-dependent deployment behavior.
Ote Binary Stdout Contract	✅ Passed	The PR changes only two comments in a Multus YAML; the repository has no OTE/openshift-tests binaries or suite setup, so this stdout contract is not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request changes only comments in bindata/network/multus/multus.yaml; no new Ginkgo e2e tests or external connectivity code is present.
No-Weak-Crypto	✅ Passed	The commit changes only two comments from “k8d” to “k8s”; no weak-crypto or secret-comparison code is added. Existing md5sum usage predates the commit.
No-Sensitive-Data-In-Logs	✅ Passed	The commit changes only two comments from “k8d” to “k8s”. It adds no logging and does not change token, hostname, or customer-data handling.
Title check	✅ Passed	The title uses the imperative mood, includes the affected component, stays under 72 characters, and accurately describes the typo correction.
Description check	✅ Passed	The description accurately explains the k8d-to-k8s typo correction in the code.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[ssonigra]

@coderabbitai regarding the pre-merge check findings:

• Title check: Fixed — title now prefixed with multus:.

• Commit Message Quality: Fixed — commit body now explains the rationale (preventing incorrect Kubernetes terminology in generated Multus configuration comments).

• Unit Tests: This is a comment-only typo fix (k8d → k8s) with zero runtime impact. No Go logic changed, no test is applicable. Please ignore this pre-merge check.

• Container-Privileges: hostNetwork: true, hostPID: true, and privileged: true are pre-existing settings required by the Multus network stack. They are not introduced or modified by this PR.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

@ssonigra Acknowledged.

I will not treat the unit-test check as blocking for this comment-only correction.

I will not treat the existing hostNetwork: true, hostPID: true, and privileged: true settings as findings for this PR. The PR does not change these settings.

The corrected PR title and commit rationale address the related pre-merge checks.

---

✏️ Learnings added

Learnt from: ssonigra
URL: https://github.com/openshift/cluster-network-operator/pull/3106

Timestamp: 2026-08-05T11:10:11.104Z
Learning: In `bindata/network/multus/multus.yaml`, the Multus network stack requires the pre-existing `hostNetwork: true`, `hostPID: true`, and `privileged: true` settings. A PR that does not modify these settings must not receive new container-privilege findings solely because they are present.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

_{You are interacting with an AI system.}

[ssonigra]

/test 5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade

[rameshsahoo11]

/lgtm

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-ovn-upgrade-ipsec

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-fdp-qe
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-windows
/test e2e-azure-ovn-upgrade
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-ovn-ipv6-ipsec
/test e2e-ovn-ipsec-step-registry
/test hypershift-e2e-aks

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rameshsahoo11, ssonigra
Once this PR has been reviewed and has the lgtm label, please assign kyrtapz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ssonigra]

/retest

[openshift-ci]

@ssonigra: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw	023a5e2	link	true	/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ssonigra]

/assign kyrtapz