OCPBUGS-32979: Update network operator status for IPsec by pperiyasamy · Pull Request #2360 · openshift/cluster-network-operator

pperiyasamy · 2024-04-26T08:54:03Z

This PR updates network operator progressing condition for rolling out IPsec daemonset for cluster. It reflects appropriate status for network cluster operator which would make openshift-install to exit gracefully after installing all of IPsec components for the cluster.

pperiyasamy · 2024-04-26T09:30:35Z

/assign @jcaamano @kyrtapz

openshift-ci-robot · 2024-04-30T08:56:55Z

@pperiyasamy: This pull request references Jira Issue OCPBUGS-32979, which is invalid:

expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR updates network operator's progressing and degraded conditions for rolling out IPsec daemonset for cluster. It reflects appropriate status for network cluster operator which would make openshift-install to exit gracefully after installing all of IPsec components for the cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pperiyasamy · 2024-04-30T08:58:01Z

/jira refresh

openshift-ci-robot · 2024-04-30T08:58:07Z

@pperiyasamy: This pull request references Jira Issue OCPBUGS-32979, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-04-30T09:29:33Z

@pperiyasamy: This pull request references Jira Issue OCPBUGS-32979, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

This PR updates network operator's progressing and degraded conditions for rolling out IPsec daemonset for cluster. It reflects appropriate status for network cluster operator which would make openshift-install to exit gracefully after installing all of IPsec components for the cluster.

Depends on: #2349

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcaamano

PTAL @kyrtapz @pliurh

I would like commit 2 general opinion here and also in context of live migration which is another functionality that depends on pool status.

I think we should reconcile on pool status changes, but regardless this makes sense.

jcaamano · 2024-04-30T09:45:32Z

@pperiyasamy please note that this will delay installs if ipsec is enabled from the get go, possibly delaying them over an installer global timeout and making them fail. We might need to account for this in ipsec CI jobs and also in docs if the default timeout is not big enough.

pperiyasamy · 2024-04-30T10:42:59Z

@pperiyasamy please note that this will delay installs if ipsec is enabled from the get go, possibly delaying them over an installer global timeout and making them fail. We might need to account for this in ipsec CI jobs and also in docs if the default timeout is not big enough.

yes @jcaamano , The ci/prow/e2e-ovn-ipsec-step-registry job is so far looking fine with change, but it would be also good to get this release PR merged (as this makes ipsec jobs to adapt with new API changes) and look for few more runs how it behaves. cc @jluhrsen

pperiyasamy · 2024-04-30T10:54:25Z

/test e2e-ovn-ipsec-step-registry

pperiyasamy · 2024-05-07T13:44:59Z

/test e2e-ovn-ipsec-step-registry

pperiyasamy · 2024-05-08T08:03:22Z

/test e2e-ovn-ipsec-step-registry

pperiyasamy · 2024-05-08T10:57:56Z

This 1788117489796780032 run shows change is in effect (here) and COs are back to running in 28mins. Would try for few more runs.

pperiyasamy · 2024-05-10T14:43:45Z

/test e2e-ovn-ipsec-step-registry

jcaamano · 2024-05-13T10:07:02Z

 	data.Data["OVNIPsecDaemonsetEnable"] = OVNIPsecDaemonsetEnable
 	data.Data["OVNIPsecEnable"] = OVNIPsecEnable

+	// Set progressing to true until IPsec DaemonSet is rendered when EW IPsec config is enabled.


@pperiyasamy can you add a TODO here explaining what we want to do in the future and/or pointing to the jira issue? thanks!

Done. Thanks a lot @jcaamano and @kyrtapz for a quick offline reviews on this PR.

This commit updates network operator progressing condition for rolling out IPsec daemonset for cluster. It reflects appropriate status for network cluster operator which would make openshift-install to exit gracefully after installing all of IPsec components for the cluster. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>

pperiyasamy · 2024-05-14T07:48:59Z

/retest

jcaamano · 2024-05-14T08:48:49Z

/lgtm
/approve

openshift-ci · 2024-05-14T08:50:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-05-14T13:01:46Z

/retest-required

Remaining retests: 0 against base HEAD 9c3a57e and 2 for PR HEAD 763c565 in total

pperiyasamy · 2024-05-15T08:34:48Z

/label acknowledge-critical-fixes-only

pperiyasamy · 2024-05-15T16:52:43Z

/retest

pperiyasamy · 2024-05-16T07:25:01Z

/retest

openshift-ci · 2024-05-16T09:55:19Z

@pperiyasamy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`763c565`	link	false	`/test security`
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	`763c565`	link	false	`/test e2e-vsphere-ovn-dualstack-primaryv6`
ci/prow/e2e-ovn-ipsec-step-registry	`763c565`	link	false	`/test e2e-ovn-ipsec-step-registry`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-05-16T09:59:41Z

@pperiyasamy: Jira Issue OCPBUGS-32979: All pull requests linked via external trackers have merged:

openshift/cluster-network-operator#2360

Jira Issue OCPBUGS-32979 has been moved to the MODIFIED state.

Details

In response to this:

This PR updates network operator progressing condition for rolling out IPsec daemonset for cluster. It reflects appropriate status for network cluster operator which would make openshift-install to exit gracefully after installing all of IPsec components for the cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-05-16T13:19:22Z

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.17.0-202405161113.p0.g0a03896.assembly.stream.el9 for distgit cluster-network-operator.
All builds following this will include this PR.

openshift-merge-robot · 2024-05-18T00:21:55Z

Fix included in accepted release 4.16.0-0.nightly-2024-05-17-180525

pperiyasamy · 2024-10-13T14:33:32Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2024-10-13T14:34:12Z

@pperiyasamy: new pull request created: #2530

Details

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci Bot requested review from trozet and tssurya April 26, 2024 08:55

openshift-ci Bot assigned jcaamano and kyrtapz Apr 26, 2024

pperiyasamy force-pushed the report-ipsec-status branch from 6def0a3 to 7598967 Compare April 30, 2024 07:06

pperiyasamy changed the title ~~Update network operator status for IPsec~~ OCPBUGS-32979: Update network operator status for IPsec Apr 30, 2024

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2024

openshift-ci Bot requested a review from anuragthehatter April 30, 2024 08:58

jcaamano reviewed Apr 30, 2024

View reviewed changes

pperiyasamy force-pushed the report-ipsec-status branch from 7598967 to 0dac514 Compare May 7, 2024 08:42

pperiyasamy force-pushed the report-ipsec-status branch from 0dac514 to 56aa983 Compare May 13, 2024 10:03

jcaamano reviewed May 13, 2024

View reviewed changes

pperiyasamy force-pushed the report-ipsec-status branch 2 times, most recently from 807c96f to 2f27c7b Compare May 13, 2024 11:19

jcaamano reviewed May 13, 2024

View reviewed changes

Comment thread pkg/network/ovn_kubernetes.go Outdated

pperiyasamy force-pushed the report-ipsec-status branch from 2f27c7b to 763c565 Compare May 13, 2024 11:40

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024

openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 15, 2024

openshift-merge-bot Bot merged commit 0a03896 into openshift:master May 16, 2024

openshift-cherrypick-robot mentioned this pull request Oct 13, 2024

[release-4.15] OCPBUGS-43268: Update network operator status for IPsec #2530

Merged

Uh oh!

Conversation

pperiyasamy commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pperiyasamy commented Apr 26, 2024

Uh oh!

openshift-ci-robot commented Apr 30, 2024

Uh oh!

pperiyasamy commented Apr 30, 2024

Uh oh!

openshift-ci-robot commented Apr 30, 2024

Uh oh!

openshift-ci-robot commented Apr 30, 2024

Uh oh!

jcaamano left a comment

Choose a reason for hiding this comment

Uh oh!

jcaamano commented Apr 30, 2024

Uh oh!

pperiyasamy commented Apr 30, 2024

Uh oh!

pperiyasamy commented Apr 30, 2024

Uh oh!

pperiyasamy commented May 7, 2024

Uh oh!

pperiyasamy commented May 8, 2024

Uh oh!

pperiyasamy commented May 8, 2024

Uh oh!

pperiyasamy commented May 10, 2024

Uh oh!

jcaamano May 13, 2024

Choose a reason for hiding this comment

Uh oh!

pperiyasamy May 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pperiyasamy commented May 14, 2024

Uh oh!

jcaamano commented May 14, 2024

Uh oh!

openshift-ci Bot commented May 14, 2024

Uh oh!

openshift-ci-robot commented May 14, 2024

Uh oh!

pperiyasamy commented May 15, 2024

Uh oh!

pperiyasamy commented May 15, 2024

Uh oh!

pperiyasamy commented May 16, 2024

Uh oh!

openshift-ci Bot commented May 16, 2024

Uh oh!

openshift-ci-robot commented May 16, 2024

Uh oh!

openshift-bot commented May 16, 2024

Uh oh!

openshift-merge-robot commented May 18, 2024

Uh oh!

pperiyasamy commented Oct 13, 2024

Uh oh!

openshift-cherrypick-robot commented Oct 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pperiyasamy commented Apr 26, 2024 •

edited

Loading