Skip to content

Add map world inverted#4189

Merged
evanpelle merged 12 commits into
openfrontio:mainfrom
PatrickPlaysBadly:Add-Map-World-Inverted
Jun 8, 2026
Merged

Add map world inverted#4189
evanpelle merged 12 commits into
openfrontio:mainfrom
PatrickPlaysBadly:Add-Map-World-Inverted

Conversation

@PatrickPlaysBadly

Copy link
Copy Markdown
Contributor

Resolves #4187

Description:

Add Map - World Inverted

1248x2500, 1,561,000 land tiles
~100 standard. Over 250+ total.
https://www.youtube.com/watch?v=w2LVZQXZoaU
https://discord.com/channels/1284581928254701718/1509034328766812210

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

PlaysBadly

add raw map files
added world inverted to go file
added world inverted to en file
added rendered map files for world inverted
updated game file with inverted world
added to mapplaylist
@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Adds the "World Inverted" map: source info.json, generator registration, compiled manifest with dimensions and nation placements, integration into GameMapType/category, playlist frequency, and English localization.

Changes

World Inverted Map Addition

Layer / File(s) Summary
Map data asset and generator registry
map-generator/assets/maps/worldinverted/info.json, map-generator/main.go
Source info.json defines the map name plus nations and additionalNations; main.go registers worldinverted so the generator will process it.
Compiled manifest with dimensions and nations
resources/maps/worldinverted/manifest.json
Adds additionalNations, map sizing metadata for multiple resolutions (map, map16x, map4x), and the nations array with many coordinate placements.
Game type, playlist, and i18n integration
src/core/game/Game.ts, src/server/MapPlaylist.ts, resources/lang/en.json
Adds GameMapType.WorldInverted, includes it in mapCategories.fantasy, adds GameMapName.WorldInverted to MapPlaylist.FREQUENCY with weight 8, and inserts map.worldInverted translation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

bypass-pr-check

Suggested reviewers

  • evanpelle

Poem

🗺️ A tilted world laid down in text,
Flags and points in careful rows,
From info to manifest, compiled next—
The game now knows where inverted winds blow. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a new map called 'World Inverted' to the system.
Description check ✅ Passed The description is directly related to the changeset, referencing issue #4187 and providing map specifications, media links, and completion of the required checklist items.
Linked Issues check ✅ Passed The PR successfully implements all coding objectives from issue #4187: new map data files added, map registered in main.go, GameMapType enum extended, playlist weighting configured, and localization string added.
Out of Scope Changes check ✅ Passed All changes are directly related to adding the 'World Inverted' map; no extraneous modifications detected outside the scope of the linked issue requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@map-generator/assets/maps/worldinverted/info.json`:
- Around line 316-317: Trim trailing spaces from all user-facing "name" values
in map JSON entries (e.g., change "Bellingshausen " -> "Bellingshausen", "SS
Florizel " -> "SS Florizel", "North " -> "North", "Bengal " -> "Bengal") and
correct obvious typos in names (e.g., "Artic" -> "Arctic", "East Pacfic Plains"
-> "East Pacific Plains"); update each matching "name" field in info.json
(including other occurrences with the same values) so displayed names are
normalized and consistent.
- Around line 745-755: The JSON array additionalNations contains a duplicate
entry for the nation with "name": "HMS Resolute"; remove the redundant object so
each nation name is unique (keep one {"name":"HMS Resolute","flag":"gb"} and
delete the other) to prevent map-authoring errors during nation creation; verify
the additionalNations array has no other duplicate "name" values before
committing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8eefa0b5-803b-4927-ae60-c3bef0eb7576

📥 Commits

Reviewing files that changed from the base of the PR and between 27517e3 and 0682e68.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/worldinverted/image.png is excluded by !**/*.png
  • resources/maps/worldinverted/map.bin is excluded by !**/*.bin
  • resources/maps/worldinverted/map16x.bin is excluded by !**/*.bin
  • resources/maps/worldinverted/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (6)
  • map-generator/assets/maps/worldinverted/info.json
  • map-generator/main.go
  • resources/maps/worldinverted/manifest.json
  • resources/maps/worldinverted/thumbnail.webp
  • src/core/game/Game.ts
  • src/server/MapPlaylist.ts

Comment thread map-generator/assets/maps/worldinverted/info.json Outdated
Comment thread map-generator/assets/maps/worldinverted/info.json Outdated
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management Jun 7, 2026
@RickD004 RickD004 added this to the v32 milestone Jun 7, 2026
corrected typos
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 7, 2026
corrected typos
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 7, 2026
updated raw map files
update rendered map files
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 7, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 7, 2026
@github-project-automation github-project-automation Bot moved this from Development to Final Review in OpenFront Release Management Jun 8, 2026
@evanpelle evanpelle merged commit 1e3f504 into openfrontio:main Jun 8, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management Jun 8, 2026
@PatrickPlaysBadly PatrickPlaysBadly deleted the Add-Map-World-Inverted branch June 8, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Add Map World Inverted

3 participants