Add map world inverted#4189
Conversation
add raw map files
added world inverted to go file
added world inverted to en file
added rendered map files for world inverted
updated game file with inverted world
added to mapplaylist
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds the "World Inverted" map: source info.json, generator registration, compiled manifest with dimensions and nation placements, integration into GameMapType/category, playlist frequency, and English localization. ChangesWorld Inverted Map Addition
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@map-generator/assets/maps/worldinverted/info.json`:
- Around line 316-317: Trim trailing spaces from all user-facing "name" values
in map JSON entries (e.g., change "Bellingshausen " -> "Bellingshausen", "SS
Florizel " -> "SS Florizel", "North " -> "North", "Bengal " -> "Bengal") and
correct obvious typos in names (e.g., "Artic" -> "Arctic", "East Pacfic Plains"
-> "East Pacific Plains"); update each matching "name" field in info.json
(including other occurrences with the same values) so displayed names are
normalized and consistent.
- Around line 745-755: The JSON array additionalNations contains a duplicate
entry for the nation with "name": "HMS Resolute"; remove the redundant object so
each nation name is unique (keep one {"name":"HMS Resolute","flag":"gb"} and
delete the other) to prevent map-authoring errors during nation creation; verify
the additionalNations array has no other duplicate "name" values before
committing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8eefa0b5-803b-4927-ae60-c3bef0eb7576
⛔ Files ignored due to path filters (4)
map-generator/assets/maps/worldinverted/image.pngis excluded by!**/*.pngresources/maps/worldinverted/map.binis excluded by!**/*.binresources/maps/worldinverted/map16x.binis excluded by!**/*.binresources/maps/worldinverted/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (6)
map-generator/assets/maps/worldinverted/info.jsonmap-generator/main.goresources/maps/worldinverted/manifest.jsonresources/maps/worldinverted/thumbnail.webpsrc/core/game/Game.tssrc/server/MapPlaylist.ts
corrected typos
corrected typos
updated raw map files
update rendered map files
I > i
Resolves #4187
Description:
Add Map - World Inverted
1248x2500, 1,561,000 land tiles
~100 standard. Over 250+ total.
https://www.youtube.com/watch?v=w2LVZQXZoaU
https://discord.com/channels/1284581928254701718/1509034328766812210
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
PlaysBadly