Skip to content

Adds onion map#4057

Merged
evanpelle merged 12 commits into
openfrontio:mainfrom
TKTK123456:Onion-map
May 29, 2026
Merged

Adds onion map#4057
evanpelle merged 12 commits into
openfrontio:mainfrom
TKTK123456:Onion-map

Conversation

@TKTK123456

@TKTK123456 TKTK123456 commented May 28, 2026

Copy link
Copy Markdown
Contributor

If this PR fixes an issue, link it below. If not, delete these two lines.
Resolves #4055

Description:

Adds a 512*512 onion map with 3 nations (Leafer Confederation, Outer Enclave and Inner Tribe)

thumbnail

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tktk1234567

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fbedf98d-cdf5-4783-94bc-d7435a7a8c3d

📥 Commits

Reviewing files that changed from the base of the PR and between 0d19fb1 and 16a1662.

📒 Files selected for processing (1)
  • resources/lang/en.json

Walkthrough

Adds the "Onion" map end-to-end: asset JSONs (info + manifest), registers "onion" in the map-generator, exposes GameMapType.Onion and adds it to mapCategories.arcade, updates playlist frequency, and adds the English locale key.

Changes

Onion Map Addition

Layer / File(s) Summary
Map configuration and definition
map-generator/assets/maps/onion/info.json, resources/maps/onion/manifest.json
info.json defines name: "onion" and three nations (Leafer Confederation, Outer Enclave, Inner Tribe) with coordinates and empty flag. manifest.json lists base, map16x, and map4x layers with dimensions/tiles and repeats the three nations with names and coordinates.
Generator registry update
map-generator/main.go
Adds "onion" to the maps registry so the generator will process the new map and locate its assets.
Game enum, category, and playlist frequency
src/core/game/Game.ts, src/server/MapPlaylist.ts
Adds GameMapType.Onion, includes it in mapCategories.arcade, and adds Onion: 2 to the playlist FREQUENCY table.
Localization
resources/lang/en.json
Adds map.onion = "Onion" to the English locale.

Sequence Diagram

sequenceDiagram
  participant MapGenerator
  participant MapsRegistry
  participant MapAssets
  participant GameCore
  participant PlaylistService
  MapGenerator->>MapsRegistry: register "onion"
  MapsRegistry->>MapAssets: load info.json & manifest.json
  GameCore->>MapsRegistry: reference GameMapType.Onion
  GameCore->>PlaylistService: include "Onion" via mapCategories
  PlaylistService->>PlaylistService: set FREQUENCY["Onion"] = 2
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • evanpelle

Poem

🧅 Onion rings of map and code,
Layers stacked in tidy mode.
Three nations set in spiral tune,
Registry, game, and playlist soon,
Players meet its roundel road.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Adds onion map' directly and clearly summarizes the main change—introducing a new onion map to the codebase.
Description check ✅ Passed The description clearly relates to the changeset, explaining that a 512×512 onion map with 3 nations is being added, and references the resolved issue #4055.
Linked Issues check ✅ Passed The PR successfully implements the objectives from issue #4055: the onion map is added with correct dimensions (512×512), includes three nations, and is integrated into arcade rotation for lobby play.
Out of Scope Changes check ✅ Passed All changes are scoped to the onion map feature: configuration files, game type definitions, playlist weighting, and localization—no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 28, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 28, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 28, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 28, 2026
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Actionable comments posted: 0

evanpelle
evanpelle previously approved these changes May 28, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Final Review in OpenFront Release Management May 28, 2026
@evanpelle evanpelle added this to the v32 milestone May 28, 2026
@evanpelle

Copy link
Copy Markdown
Collaborator

looks like a conflict

@TKTK123456 TKTK123456 dismissed stale reviews from evanpelle and coderabbitai[bot] via 0d19fb1 May 28, 2026 23:18
@TKTK123456

Copy link
Copy Markdown
Contributor Author

@coderabbitai resume

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Reviews resumed.

@TKTK123456 TKTK123456 requested a review from evanpelle May 28, 2026 23:22
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 28, 2026
@TKTK123456

Copy link
Copy Markdown
Contributor Author

@evanpelle fixed

@evanpelle evanpelle merged commit 9d4080f into openfrontio:main May 29, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management May 29, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Jun 1, 2026
3 tasks
@TKTK123456 TKTK123456 deleted the Onion-map branch June 2, 2026 00:41
This was referenced Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Feature: Onion Map

2 participants