Skip to content

Allow overriding some more Makefile variables#16

Merged
mcayland merged 1 commit into
openbios:masterfrom
lemenkov:destdir_flexibility
Apr 24, 2024
Merged

Allow overriding some more Makefile variables#16
mcayland merged 1 commit into
openbios:masterfrom
lemenkov:destdir_flexibility

Conversation

@lemenkov

@lemenkov lemenkov commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

This PR lets anyone to override a few extra variables

  • DESTDIR can be set to anything ( /usr for example or any $BUILDROOT/usr)
  • STRIP can be set to /bin/true to avoid stripping of debug symbols
  • CFLAGS can be set to any preferred value (at your own risk)

Fixes #15.

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
@mcayland mcayland merged commit 7cddcb0 into openbios:master Apr 24, 2024
@mcayland

Copy link
Copy Markdown
Collaborator

Thanks! This looks good to me, so I've merged it.

@emixa-d

emixa-d commented Apr 25, 2024

Copy link
Copy Markdown

This does not fix #15! This PR only allows overriding DESTDIR (and STRIP and CFLAGS, but that has nothing to do with #15). It still uses DESTDIR and PREFIX incorrectly. Please read the things I linked to in #15 (here's an updated link, as one of them appears to be broken):

https://people.freebsd.org/~olivierd/porters-handbook/porting-prefix.html#:~:text=PREFIX%20determines%20where%20the%20port,the%20value%20of%20this%20variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PREFIX / DESTDIR handled incorrectly in Makefiles

3 participants