fix: support sequence metric attributes in view aggregation keys - #5341
fix: support sequence metric attributes in view aggregation keys#5341naveenvenk17 wants to merge 1 commit into
Conversation
|
|
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
|
I think there's a PR out that addresses this issue already? #5303 |
|
This needs a changelog entry in |
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
Pull request dashboard statusWaiting on the author · refreshed 2026-08-14 16:52 UTC Respond to 2 review items (e.g. link a commit, explain why not, ask a follow-up): Status above doesn't look right?
|
Fixes #3750.
Summary
frozenset(attributes.items()).get_dict_as_keyhelper fromlistvalues to non-string sequence values.Evidence
.tox\\py312-test-opentelemetry-sdk\\Scripts\\pytest.exe opentelemetry-sdk\\tests\\metrics\\test_view_instrument_match.py -qpassed:11 passed.uv run ruff check opentelemetry-sdk\\src\\opentelemetry\\sdk\\metrics\\_internal\\_view_instrument_match.py opentelemetry-sdk\\src\\opentelemetry\\sdk\\util\\__init__.py opentelemetry-sdk\\tests\\metrics\\test_view_instrument_match.pypassed..tox\\lint-opentelemetry-sdk\\Scripts\\pylint.exe opentelemetry-sdk\\src\\opentelemetry\\sdk\\metrics\\_internal\\_view_instrument_match.py opentelemetry-sdk\\src\\opentelemetry\\sdk\\util\\__init__.py opentelemetry-sdk\\tests\\metrics\\test_view_instrument_match.pypassed:10.00/10.uv run tox -e py312-test-opentelemetry-sdk -- opentelemetry-sdk/tests/metrics/test_view_instrument_match.pypassed:1098 passed, 13 skipped.git diff --checkpassed.