Remove packaging as a runtime dependency of opentelemetry-instrumentation-flask - #4889
Draft
ocelotl wants to merge 2 commits into
Draft
Remove packaging as a runtime dependency of opentelemetry-instrumentation-flask#4889ocelotl wants to merge 2 commits into
packaging as a runtime dependency of opentelemetry-instrumentation-flask#4889ocelotl wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
packagingas a runtime dependency ofopentelemetry-instrumentation-flask.The
flask.__version__comparison now uses the internal PEP 440Versionfromopentelemetry.instrumentation._packaging.version(provided byopentelemetry-instrumentation) instead ofpackaging, andpackagingisdropped from this package's
dependencies.Fixes #4885
Type of change
How Has This Been Tested?
Behavior is unchanged; the version-comparison call sites are identical apart from
the import source. Covered by the existing test suite for this instrumentation
once #4882 is merged and this branch is rebased.
Does This PR Require a Core Repo Change?
Checklist: