[sdk-metrics] Expose ExemplarReservoir and support configuration via views by CodeBlanch · Pull Request #5542 · open-telemetry/opentelemetry-dotnet

CodeBlanch · 2024-04-17T17:12:32Z

Changes

Expose ExemplarReservoir in pre-release builds.
Expose MetricStreamConfiguration.ExemplarReservoirFactory in pre-release builds.

Details

This is being done to be complaint with the view configuration spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#stream-configuration

Note: At the moment everything on Exemplar has a private setter and the Update method is internal so there isn't really a good practical way to make a custom ExemplarReservoir. I'm going to tackle that as a follow-up because there are different approaches we could take.

Merge requirement checklist

CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
Appropriate CHANGELOG.md files updated for non-trivial changes
Changes in public API reviewed (if applicable)

cijothomas · 2024-04-17T17:21:02Z

Is Exemplar stable release planned for 1.9.0 ? if yes, can we just expose this unconditionally? Or are you anticipating that 1.9.0 stable won't have stable exemplars, and hence this PR?

codecov · 2024-04-17T17:21:43Z

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 85.56%. Comparing base (6250307) to head (15e1cea).
Report is 182 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5542      +/-   ##
==========================================
+ Coverage   83.38%   85.56%   +2.18%     
==========================================
  Files         297      289       -8     
  Lines       12531    12484      -47     
==========================================
+ Hits        10449    10682     +233     
+ Misses       2082     1802     -280

Flag	Coverage Δ
unittests	`?`
unittests-Solution-Experimental	`85.39% <54.54%> (?)`
unittests-Solution-Stable	`85.52% <50.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...penTelemetry/Metrics/Exemplar/ExemplarReservoir.cs	`100.00% <ø> (ø)`
...OpenTelemetry/Metrics/MetricStreamConfiguration.cs	`88.88% <100.00%> (+13.88%)`	⬆️
src/OpenTelemetry/Metrics/MetricPoint.cs	`94.24% <60.00%> (+25.76%)`	⬆️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs	`79.31% <40.00%> (-2.60%)`	⬇️

... and 76 files with indirect coverage changes

CodeBlanch · 2024-04-17T17:38:02Z

@cijothomas

Is Exemplar stable release planned for 1.9.0 ? if yes, can we just expose this unconditionally? Or are you anticipating that 1.9.0 stable won't have stable exemplars, and hence this PR?

Yes it is planned for 1.9.0. I don't think we're ready to remove experimental status yet though. I want to finish implementing the spec and wait for it go stable before we do that. Probably just a final PR at the end of the effort which makes the switch for everything.

## Changes Update the compliance matrix for .NET as of 1.16.0 of the .NET SDK. I got Copilot to do most of the work of researching what was missing that had been implementing and finding the relevant PRs that implemented then. I cross checked the PRs _looked_ correct, but some of it might be incorrect, particularly things that seem to have been implemented for a while and predate my contributions to OTel. I then had Claude review the changes and cross-reference, which fixed some of the entries, but again there might still be some mistakes. ~~Some of the entries might only be available as experimental features, so maybe they shouldn't be updated?~~ Experimental entries removed, now marked as ~~strikethrough~~ below. Entries updated with relevant PR links where appropriate below. /cc @open-telemetry/dotnet-maintainers ### Traces - Get a Tracer with schema_url: open-telemetry/opentelemetry-dotnet#6736 - Get a Tracer with scope attributes: open-telemetry/opentelemetry-dotnet#6137 - Associate Tracer with InstrumentationScope: open-telemetry/opentelemetry-dotnet#239 - Fetch InstrumentationScope from ReadableSpan: open-telemetry/opentelemetry-dotnet#679 ### Metrics - Associate Meter with InstrumentationScope: open-telemetry/opentelemetry-dotnet#6714 - Gauge instrument is supported: open-telemetry/opentelemetry-dotnet#5867 - Valid instrument created / warning for duplicate name: open-telemetry/opentelemetry-dotnet#2916 - Duplicate instrument registration resolved by first-seen: open-telemetry/opentelemetry-dotnet#2916 - Instrument names conform to specified syntax: open-telemetry/opentelemetry-dotnet#3821 - Instrument supports advisory ExplicitBucketBoundaries: open-telemetry/opentelemetry-dotnet#5854 - Instrument supports advisory Attributes: Not implemented - name/version/schema_url create InstrumentationScope: open-telemetry/opentelemetry-dotnet#6714 - ~~View allows configuring name, description, attributes, aggregation: open-telemetry/opentelemetry-dotnet#2396 - ~~View allows configuring exemplar reservoir: open-telemetry/opentelemetry-dotnet#5558 - Metrics Reader supports default aggregation config: open-telemetry/opentelemetry-dotnet#6778 - Metrics Reader supports default temporality config: open-telemetry/opentelemetry-dotnet#4667 - ~~ExemplarReservoir interface/extension point: open-telemetry/opentelemetry-dotnet#5542 - ~~ExemplarReservoir has offer method: open-telemetry/opentelemetry-dotnet#5542 - SimpleFixedSizeExemplarReservoir: open-telemetry/opentelemetry-dotnet#4256 - AlignedHistogramBucketExemplarReservoir: open-telemetry/opentelemetry-dotnet#4119 ### Logs - ~~LoggerProvider.GetLogger: open-telemetry/opentelemetry-dotnet#4422 - LoggerProvider.GetLogger accepts attributes: Not implemented - LoggerProvider.Shutdown: open-telemetry/opentelemetry-dotnet#5648 - LoggerProvider.ForceFlush: open-telemetry/opentelemetry-dotnet#5648 - Logger.Emit(LogRecord) with Exception parameter: Not implemented - ~~LogRecord.Set EventName: open-telemetry/opentelemetry-dotnet#6306 - Logger.Enabled: Not implemented - Ergonomic API (ILogger bridge): open-telemetry/opentelemetry-dotnet#3489 - SimpleLogRecordProcessor: open-telemetry/opentelemetry-dotnet#1622 - BatchLogRecordProcessor: open-telemetry/opentelemetry-dotnet#1622 - Can plug custom LogRecordProcessor: open-telemetry/opentelemetry-dotnet#4916 - LogRecordProcessor.Enabled: Not implemented - Can plug custom LogRecordExporter: open-telemetry/opentelemetry-dotnet#1622 ### Context Propagation - Jaeger Propagator: open-telemetry/opentelemetry-dotnet#3309 - TextMapPropagator: open-telemetry/opentelemetry-dotnet#1427 ### Environment Variables - OTEL_SDK_DISABLED: open-telemetry/opentelemetry-dotnet#6568 - OTEL_LOGRECORD_ATTRIBUTE_COUNT_LIMIT: open-telemetry/opentelemetry-dotnet#4887 - OTEL_LOGRECORD_ATTRIBUTE_VALUE_LENGTH_LIMIT: open-telemetry/opentelemetry-dotnet#4887 - OTEL_TRACES_SAMPLER: open-telemetry/opentelemetry-dotnet#5448 - OTEL_TRACES_SAMPLER_ARG: open-telemetry/opentelemetry-dotnet#5448 - OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION: open-telemetry/opentelemetry-dotnet#6778 ### Exporters — OTLP - OTLP/HTTP gzip Content-Encoding support: open-telemetry/opentelemetry-dotnet#7055 - ~~Honors retryable responses with backoff: open-telemetry/opentelemetry-dotnet#5495 - ~~Honors non-retryable responses: open-telemetry/opentelemetry-dotnet#5495 - ~~Honors throttling response: open-telemetry/opentelemetry-dotnet#5495 - Metric Exporter configurable temporality preference: open-telemetry/opentelemetry-dotnet#4667 - Metric Exporter configurable default aggregation: open-telemetry/opentelemetry-dotnet#6778 ### Exporters — Zipkin - InstrumentationScope mapping: open-telemetry/opentelemetry-dotnet#5473 ### Exporters — Prometheus - Metadata Deduplication: open-telemetry/opentelemetry-dotnet#7237 - otel_scope_name and otel_scope_version labels: open-telemetry/opentelemetry-dotnet#7237 - otel_scope_[attribute] labels: open-telemetry/opentelemetry-dotnet#7237 - Prometheus Counters have _total suffix by default: open-telemetry/opentelemetry-dotnet#5305 - Prometheus Counters _total suffixing can be disabled: open-telemetry/opentelemetry-dotnet#5305 - Colliding sanitized attribute keys are merged: open-telemetry/opentelemetry-dotnet#7239 - Exemplars for Histograms and Monotonic sums: open-telemetry/opentelemetry-dotnet#7222 - target_info metric from Resource: open-telemetry/opentelemetry-dotnet#5407 ### OpenTracing Compatibility - Create OpenTracing Shim: open-telemetry/opentelemetry-dotnet#197 - Tracer shim: open-telemetry/opentelemetry-dotnet#197 - Span shim: open-telemetry/opentelemetry-dotnet#197 - SpanContext shim: open-telemetry/opentelemetry-dotnet#197 - ScopeManager shim: open-telemetry/opentelemetry-dotnet#197 - Error mapping for attributes/events: open-telemetry/opentelemetry-dotnet#197

CodeBlanch added 4 commits April 16, 2024 15:28

Work to expose ExemplarReservoir as defined by the spec.

d2919df

Merge branch 'main' into sdk-metrics-expose-exemplarreservoir

98feeb2

Update api files.

d92a49c

CHANGELOG stub.

81bb2cc

CodeBlanch added pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package metrics Metrics signal related labels Apr 17, 2024

CodeBlanch requested a review from a team April 17, 2024 17:12

CHANGELOG patch.

304836e

Lint.

d442710

Lint fixes, notes, and logging.

15e1cea

cijothomas approved these changes Apr 17, 2024

View reviewed changes

rajkumar-rangaraj approved these changes Apr 17, 2024

View reviewed changes

CodeBlanch merged commit 89aa7a4 into open-telemetry:main Apr 17, 2024

CodeBlanch deleted the sdk-metrics-expose-exemplarreservoir branch April 17, 2024 22:49

CodeBlanch mentioned this pull request Apr 17, 2024

Exemplar - expose ExemplarReservoir and enable View based config #5334

Closed

This was referenced Sep 8, 2025

Bump OpenTelemetry from 1.8.1 to 1.12.0 neil-gilbert/CodePunk#8

Closed

Bump OpenTelemetry and OpenTelemetry.Exporter.Console neil-gilbert/CodePunk#9

Merged

Bump OpenTelemetry and OpenTelemetry.Extensions.Hosting neil-gilbert/CodePunk#10

Merged

This was referenced Oct 29, 2025

chore(csharp): Bump OpenTelemetry from 1.8.1 to 1.13.1 adbc-drivers/bigquery#16

Closed

chore(csharp): Bump OpenTelemetry and OpenTelemetry.Exporter.InMemory adbc-drivers/bigquery#17

Closed

This was referenced Nov 10, 2025

Bump Azure.Monitor.OpenTelemetry.Exporter and OpenTelemetry.Extensions.Hosting koralium/flowtide#917

Closed

Bump Azure.Monitor.OpenTelemetry.Exporter and OpenTelemetry.Extensions.Hosting koralium/flowtide#921

Merged

This was referenced Dec 1, 2025

Bump Azure.Monitor.OpenTelemetry.Exporter and OpenTelemetry.Extensions.Hosting jodavis/AdaptiveRemote#27

Closed

Bump Azure.Monitor.OpenTelemetry.Exporter and OpenTelemetry.Extensions.Hosting jodavis/AdaptiveRemote#33

Merged

dependabot Bot mentioned this pull request Feb 4, 2026

Package Dependencies: Bump the otel group with 6 updates hamadoumana/msvc-product-net-core#78

Open

dependabot Bot mentioned this pull request Feb 26, 2026

Bump OpenTelemetry.Extensions.Hosting from 1.8.1 to 1.15.0 JM-A21/GraphMailRelay#65

Merged

dependabot Bot mentioned this pull request Apr 2, 2026

deps: Bump the opentelemetry group with 5 updates MapColonies/GpkgMerger#236

Closed

martincostello mentioned this pull request Jun 24, 2026

Update .NET compliance matrix entries open-telemetry/opentelemetry-specification#5176

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[sdk-metrics] Expose ExemplarReservoir and support configuration via views#5542

[sdk-metrics] Expose ExemplarReservoir and support configuration via views#5542
CodeBlanch merged 7 commits into
open-telemetry:mainfrom
CodeBlanch:sdk-metrics-expose-exemplarreservoir

CodeBlanch commented Apr 17, 2024 •

edited

Loading

Uh oh!

cijothomas commented Apr 17, 2024

Uh oh!

codecov Bot commented Apr 17, 2024 •

edited

Loading

Uh oh!

CodeBlanch commented Apr 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

CodeBlanch commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Details

Merge requirement checklist

Uh oh!

cijothomas commented Apr 17, 2024

Uh oh!

codecov Bot commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

CodeBlanch commented Apr 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CodeBlanch commented Apr 17, 2024 •

edited

Loading

codecov Bot commented Apr 17, 2024 •

edited

Loading