Skip to content

[Instrumentation.GrpcNetClient] Support only stable HTTP semantic convention#5259

Merged
alanwest merged 6 commits into
open-telemetry:mainfrom
Kielek:grpncnetclient-drop-supporto-for-old-http-sem-conv
Jan 27, 2024
Merged

[Instrumentation.GrpcNetClient] Support only stable HTTP semantic convention#5259
alanwest merged 6 commits into
open-telemetry:mainfrom
Kielek:grpncnetclient-drop-supporto-for-old-http-sem-conv

Conversation

@Kielek

@Kielek Kielek commented Jan 26, 2024

Copy link
Copy Markdown
Member

Fixes # N/A
Design discussion issue # N/A

Changes

Drop support for old semantic convention in GrpcNetClient instrumenation

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek changed the title [Instrumentation.GrpcNetClient] Support only stable HTTP semantic con… [Instrumentation.GrpcNetClient] Support only stable HTTP semantic convention Jan 26, 2024
@Kielek
Kielek force-pushed the grpncnetclient-drop-supporto-for-old-http-sem-conv branch from 388310c to 01d168b Compare January 26, 2024 07:21
@Kielek
Kielek force-pushed the grpncnetclient-drop-supporto-for-old-http-sem-conv branch from 01d168b to 9ca3aaf Compare January 26, 2024 07:33
@codecov

codecov Bot commented Jan 26, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (6250307) 83.38% compared to head (0d4f0c0) 83.01%.
Report is 37 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5259      +/-   ##
==========================================
- Coverage   83.38%   83.01%   -0.37%     
==========================================
  Files         297      272      -25     
  Lines       12531    11965     -566     
==========================================
- Hits        10449     9933     -516     
+ Misses       2082     2032      -50     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 24.92% <93.75%> (?)
unittests-Instrumentation-Stable 24.92% <93.75%> (?)
unittests-Solution-Experimental 82.99% <54.28%> (?)
unittests-Solution-Stable 82.74% <54.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...etryProtocol/Implementation/ExperimentalOptions.cs 100.00% <ø> (ø)
...tation/OpenTelemetryProtocolExporterEventSource.cs 100.00% <100.00%> (ø)
...rotocol/Implementation/OtlpLogRecordTransformer.cs 93.45% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 89.79% <100.00%> (+0.21%) ⬆️
...AspNetCore/Implementation/HttpInMetricsListener.cs 89.74% <100.00%> (+0.26%) ⬆️
....GrpcNetClient/GrpcClientInstrumentationOptions.cs 100.00% <ø> (+25.00%) ⬆️
...ent/Implementation/GrpcClientDiagnosticListener.cs 75.80% <100.00%> (-2.77%) ⬇️
...n.GrpcNetClient/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...plementation/HttpWebRequestActivitySource.netfx.cs 80.77% <100.00%> (ø)
...emetry/Metrics/Exemplar/SimpleExemplarReservoir.cs 80.43% <100.00%> (ø)
... and 1 more

... and 33 files with indirect coverage changes

@Kielek
Kielek marked this pull request as ready for review January 26, 2024 07:42
@Kielek
Kielek requested a review from a team January 26, 2024 07:42
Comment thread src/OpenTelemetry.Instrumentation.GrpcNetClient/CHANGELOG.md Outdated
Comment thread src/OpenTelemetry.Instrumentation.GrpcNetClient/CHANGELOG.md Outdated
Comment thread src/OpenTelemetry.Instrumentation.GrpcNetClient/CHANGELOG.md Outdated
Co-authored-by: Reiley Yang <reyang@microsoft.com>
@Kielek

Kielek commented Jan 26, 2024

Copy link
Copy Markdown
Member Author

@reyang, @cijothomas, all comments for changeling handled by Reiley suggestion.

[issue](https://github.com/open-telemetry/opentelemetry-dotnet/issues/5092)
for details and workaround.
([#5077](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5077))
* Removed `OTEL_SEMCONV_STABILITY_OPT_IN` environment variable support. The

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question .. The grpc conventions are still not stable and this instrumentaion is still emitting them. Should we explicitly call it out, to avoid giving the feel that the entire conventions emitted by this is stable?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, folks who want to spend time reading changelog should already know semver2.

@alanwest alanwest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. The changelog was probably clear enough before, but just adding a suggestion making it a bit more precise.

Comment thread src/OpenTelemetry.Instrumentation.GrpcNetClient/CHANGELOG.md Outdated
Kielek and others added 2 commits January 27, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants