[Instrumentation.AspNet] Spans - semantic convention v1.24.0

[Kielek]

Fixes N/A

Changes

Span attributes based on HTTP semantic convention v1.24.0 - Common and Server part sections.

Span names:

• Span names: 87bf97b

Common part

• error.type - ccb1d4f
• http.request.method and http.request.method_original - e31b687
• http.response.header.<key> - Opn-In - skipping for now
• http.response.status_code - 5677f4f
• network.peer.address and network.peer.port - Recommended - skipping for now
• network.protocol.name - empty, means HTTP by default
• network.protocol.version - a794951
• network.transport - Opn-In - skipping for now

Server part:

• client.address - Recommended - skipping for now
• client.port - Opt-In skipping for now
• http.request.header.<key> - Opt-In skipping for now
• http.route - already handled, no changes
• network.local.address and network.local.port - Opt-In skipping for now
• server.address and server.port - 3d3ce2e
• url.path - 86fdf5a
• url.query - e920468
• url.scheme - 445a684
• user_agent.original - 78e266a

Consider to review commits separately.

For significant contributions please make sure you have completed the following items:

• Appropriate CHANGELOG.md updated for non-trivial changes
• [ ] Design discussion issue #
• [ ] Changes in public API reviewed

[codecov]

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.84%. Comparing base (71655ce) to head (8d441c0).
Report is 901 commits behind head on main.

Files with missing lines	Patch %	Lines
...umentation.AspNet/Implementation/HttpInListener.cs	95.83%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1607      +/-   ##
==========================================
- Coverage   73.91%   65.84%   -8.08%     
==========================================
  Files         267      233      -34     
  Lines        9615     8728     -887     
==========================================
- Hits         7107     5747    -1360     
- Misses       2508     2981     +473     

Flag	Coverage Δ
unittests-Extensions	∅ <ø> (?)
unittests-ResourceDetectors.ProcessRuntime	∅ <ø> (?)
unittests-Solution	6.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ion.AspNet/Implementation/HttpInMetricsListener.cs	97.36% <100.00%> (-2.64%)	⬇️
...ntation.AspNet/Implementation/RequestDataHelper.cs	100.00% <100.00%> (ø)
...umentation.AspNet/Implementation/HttpInListener.cs	87.50% <95.83%> (-0.82%)	⬇️

... and 220 files with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[vishweshbankwar]

@Kielek - Does spec requires it to be without ?

[Kielek]

I am not sure if it hard requierment, but all examples are without this sign.

[vishweshbankwar]

Looks like it doesn't include the ? component, https://www.rfc-editor.org/rfc/rfc3986#section-3.4

[vishweshbankwar]

Could you please include the details on new versus old attributes?

Something like this: https://opentelemetry.io/blog/2023/http-conventions-declared-stable/#summary-of-changes

[vishweshbankwar]

LGTM overall - suggested change on changelog.

[Kielek]

@vishweshbankwar, changes in changelog: fb25884, please review once more time.