Skip to content

fix: Change registration to use the Isolated API instead of global singleton #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
askpt merged 3 commits into from
May 22, 2026
Merged

fix: Change registration to use the Isolated API instead of global singleton #760

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9515932
fix: Register isolated API instance as singleton in OpenFeature servi…
askpt May 21, 2026
b34e7f8
fix: Update comment for singleton registration of isolated API instan…
askpt May 21, 2026
f7cac98
fix: Update singleton registration for isolated API instance to use l…
askpt May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/OpenFeature.Hosting/OpenFeatureServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using Microsoft.Extensions.Options;
using OpenFeature.Hosting;
using OpenFeature.Hosting.Internal;
using OpenFeature.Isolated;

namespace OpenFeature;

Expand All @@ -24,7 +25,9 @@ public static IServiceCollection AddOpenFeature(this IServiceCollection services
Guard.ThrowIfNull(configure);

// Register core OpenFeature services as singletons.
services.TryAddSingleton(Api.Instance);
#pragma warning disable OFISO001 // Registering the isolated API instance as a singleton is intentional to ensure that all components within the application use the same isolated instance of the OpenFeature API. This design choice allows for the container to manage the lifecycle of the isolated API instance effectively.
services.TryAddSingleton(OpenFeatureFactory.CreateIsolated());
#pragma warning restore OFISO001
Comment thread
askpt marked this conversation as resolved.
services.TryAddSingleton<IFeatureLifecycleManager, FeatureLifecycleManager>();

var builder = new OpenFeatureBuilder(services);
Expand Down
Loading