Skip to content

rescue oauth2 timeout - #169

Merged
BobbyMcWho merged 3 commits into
omniauth:masterfrom
nov:feature/oauth2_timeout
Jul 18, 2023
Merged

rescue oauth2 timeout#169
BobbyMcWho merged 3 commits into
omniauth:masterfrom
nov:feature/oauth2_timeout

Conversation

@nov

@nov nov commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

@nov nov mentioned this pull request Jul 11, 2023
@BobbyMcWho BobbyMcWho closed this Jul 18, 2023
@BobbyMcWho BobbyMcWho reopened this Jul 18, 2023
@BobbyMcWho
BobbyMcWho merged commit ed39610 into omniauth:master Jul 18, 2023
@nov

nov commented Jul 20, 2023

Copy link
Copy Markdown
Contributor Author

Do you have any plan to publish new version of this gem?

Our app has a monkey patch for the error handling added here.
We're looking for the new version, so that we can get rid of our monkey patch.

@BobbyMcWho

Copy link
Copy Markdown
Member

When I've got a chance to I will

@jessieay

Copy link
Copy Markdown

Awesome! Thanks for the PR @nov and thanks for reviewing and merging @BobbyMcWho 🌈

@nov

nov commented Jan 10, 2025

Copy link
Copy Markdown
Contributor Author

any chance to release this change as new version of gem??

@jduarte

jduarte commented Dec 10, 2025

Copy link
Copy Markdown

Hi @BobbyMcWho 👋

Would it be possible to cut a new release that includes this fix? The last release (v1.8.0) was in June 2022 and it seems that this and other meaningful work is still unreleased

We're currently using a workaround to handle OAuth2 timeouts, and having this in an official release would allow us to remove our monkey patch and keep our dependencies up-to-date.

If there's anything I can do to help make this happen, please let me know! happy to assist with testing or anything else needed.

Thanks for maintaining this gem!

@BobbyMcWho

Copy link
Copy Markdown
Member

Yes, apologies, when this was merged I was working at an Elixir shop and didn't have things set up and authed to release.

@BobbyMcWho

Copy link
Copy Markdown
Member

Release v1.9.0 available on Rubygems

@jduarte

jduarte commented Dec 11, 2025

Copy link
Copy Markdown

No apologies needed at all! Totally get that time is short and you're busy. Really appreciate you getting the new release. This will help us clean up our codebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants