Document priorityClassName - #511
Merged
Merged
Conversation
Signed-off-by: Agustín Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Díaz <agustin.ramiro.diaz@gmail.com>
AgustinRamiroDiaz
requested review from
omnomagonz,
pchico83 and
rberrelleza
as code owners
October 10, 2023 18:06
✅ Deploy Preview for okteto-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pchico83
reviewed
Oct 10, 2023
pchico83
left a comment
pchico83
left a comment
Contributor
There was a problem hiding this comment.
NodeRedinessChecker is internal, but for other ones, I would create the sections, or file issues to document them. Especially, the migration job should be documented
Signed-off-by: Agustín Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Díaz <agustin.ramiro.diaz@gmail.com>
3 tasks
Contributor
Author
|
Deferred documentation of the sections to #513 |
pchico83
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented in https://github.com/okteto/app/pull/7309
Some missing configurations I didn't add due to their sections not being present:
Should I create their sections?