fix(book): use fa-github so the header icon actually renders#28
Merged
Conversation
The bundled FontAwesome 4.7.0 CSS defines .fa-github (codepoint f09b) but has no .fab-* brand classes, so `fab-github` produced an empty <i> in the top-right menu bar. Switching to `fa-github` renders the icon as intended on both the EN and 中文 builds.
Adds a small custom.css to both book builds: - `.right-buttons` becomes a flexbox so the GitHub anchor can be ordered before the print anchor via `:has(#git-repository-button)`, placing the repo icon as the leftmost item in the right cluster. - Menu-bar icons (left-buttons + right-buttons) bump to 1.4em for better visibility on the deployed site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git-repository-iconfromfab-githubtofa-githubin both the EN and 中文 book configs so the top-right menu-bar icon actually renders.Why
mdbook 0.4.52 ships FontAwesome 4.7.0, whose CSS defines
.fa-github(glyph\f09b) but has no.fab-*brand classes. Withfab-github, the<i id="git-repository-button" class="fa fab-github">element was emitted into the header but produced no visible glyph — so the repo link was effectively invisible on https://odysa.github.io/mini-claw-code/.Test plan
mdbook build mini-claw-code-bookand openbook/index.html— GitHub icon visible top-right, links to the repo.mdbook build mini-claw-code-book-zhand openbook/index.html— same, on the 中文 build.