fix(rpc): restore process cwd inheritance on macOS#15552
Merged
Conversation
The long Unix socket workaround sets a per-thread cwd. Restoring it with pthread_chdir leaves the override active, so the thread no longer follows changes to the process-wide cwd. Reset the per-thread cwd with pthread_fchdir(-1), and cover the behavior with a macOS regression test. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The long Unix socket workaround sets a per-thread cwd. Restoring it with
pthread_chdir leaves the override active, so the thread no longer follows
changes to the process-wide cwd.
Reset the per-thread cwd with pthread_fchdir(-1), and cover the behavior
with a macOS regression test.