feat: install entries concurrently#13054
Open
anmonteiro wants to merge 2 commits into
Open
Conversation
anmonteiro
force-pushed
the
anmonteiro/concurrent-install
branch
from
December 26, 2025 20:55
592f3c8 to
1f032d4
Compare
anmonteiro
marked this pull request as ready for review
December 26, 2025 21:13
rgrinberg
reviewed
Dec 27, 2025
| files_deleted_in := Path.Set.add !files_deleted_in dir; | ||
| Fiber.return entry | ||
| | Install -> | ||
| install_entry |
Member
There was a problem hiding this comment.
I think this function prints. So we need to delay printing until everything is installed to maintain deterministic order
Collaborator
Author
There was a problem hiding this comment.
The removal operations also print. I'm assuming what we should do here is:
- collect all the operations we try to perform
- sort them, print them in order
Member
There was a problem hiding this comment.
Sure that sounds fine. Though you don't necessarily need to sort, if you just preserve the order we have now, that would also be good enough.
Member
|
I think you need to use |
anmonteiro
changed the title
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/concurrent-install
branch
4 times, most recently
from
July 19, 2026 22:46
8f39014 to
8be9417
Compare
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/concurrent-install
branch
from
July 19, 2026 22:59
8be9417 to
3879c4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.