Handle UNC paths in Node DevTools links#8365
Open
landeqiming666 wants to merge 2 commits into
Open
Conversation
Author
|
Hi, a brief follow-up on this PR. It remains clean and mergeable and keeps the fix scoped to UNC path handling in Node DevTools links, with regression coverage for the affected path forms. Happy to make any adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4269
Validation
git diff --checkgit apply -p0 --check patch/patches/devtools.patchagainst DevTools frontend revision6efd6eb1d85fd67fdcc2385c54fa56c524bec3f7The full NW.js browser test was not run locally because it requires a Chromium/NW.js
outbuild.