Skip to content

Handle UNC paths in Node DevTools links#8365

Open
landeqiming666 wants to merge 2 commits into
nwjs:mainfrom
landeqiming666:enhance-devtools-node-paths
Open

Handle UNC paths in Node DevTools links#8365
landeqiming666 wants to merge 2 commits into
nwjs:mainfrom
landeqiming666:enhance-devtools-node-paths

Conversation

@landeqiming666

Copy link
Copy Markdown

Summary

Fixes #4269

Validation

  • git diff --check
  • git apply -p0 --check patch/patches/devtools.patch against DevTools frontend revision 6efd6eb1d85fd67fdcc2385c54fa56c524bec3f7
  • Focused Node.js checks for POSIX, Windows drive, UNC, and regular URL inputs

The full NW.js browser test was not run locally because it requires a Chromium/NW.js out build.

@landeqiming666

Copy link
Copy Markdown
Author

Hi, a brief follow-up on this PR. It remains clean and mergeable and keeps the fix scoped to UNC path handling in Node DevTools links, with regression coverage for the affected path forms. Happy to make any adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.13 beta4 - devtools / source not found when clicking links from console

2 participants