adds support for fn as a modifier key - #169
Merged
Merged
Conversation
Member
|
Hi @smithkyle 👋 I'm quite busy at the moment, will try to get back to you as soon as things calmed down. Sorry for the delay |
Contributor
Author
|
No problem at all! :) |
Contributor
Author
|
It looks like some keys implicitly set the Fn modifier per this: But that doesn't explain why Fn+Backspace doesn't work... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fn key (at least on macOS) is actually a modifier key, so this commit adds support for it to be used as such...the only thing is...is that it doesn't actually seem to operate the same way as on the physical keyboard. For example, "Fn Backspace" should send "Delete", but it ends up just sending "Backspace" again. Based on my testing, "Fn" is being seen as a modifier, but it doesn't actually seem to be modifying. I'm not sure if this is the expected behavior since there are, indeed, separate keycodes for Backspace and Delete.
I initially came down this path hoping to get around the missing "Enter" keycode I implemented in #168. I was hoping I could just get around it by sending Fn + Return, but it didn't work. Based on how the other modifier keys are implemented, I believe I have implemented Function correctly, but have not seen the expected results.
Looking for some guidance... thanks!