XLSX Multibyte column fix - #2
Closed
anttir- wants to merge 1 commit into
Closed
Conversation
…e same Index value of 26.
Member
|
Thanks, I incorporated the fix, although a bit differently; also removed some unnecessary code. |
pilsetnieks
added a commit
that referenced
this pull request
Apr 18, 2015
- Implemented SeekableIterator. Thanks to [paales](https://github.com/paales) for suggestion ([Issue #54](#54) and [Pull request #55](#55)). - Fixed a bug in CSV and ODS reading where reading position 0 multiple times in a row would result in internal pointer being advanced and reading the next line. (E.g. reading row #0 three times would result in rows #0, #1, and #2.). This could have happened on multiple calls to `current()` while in #0 position, or calls to `seek(0)` and `current()`.
ChrisJasperse
pushed a commit
to ho-nl-fork/spreadsheet-reader
that referenced
this pull request
Apr 4, 2016
- Implemented SeekableIterator. Thanks to [paales](https://github.com/paales) for suggestion ([Issue nuovo#54](nuovo#54) and [Pull request nuovo#55](nuovo#55)). - Fixed a bug in CSV and ODS reading where reading position 0 multiple times in a row would result in internal pointer being advanced and reading the next line. (E.g. reading row #0 three times would result in rows #0, nuovo#1, and nuovo#2.). This could have happened on multiple calls to `current()` while in #0 position, or calls to `seek(0)` and `current()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All columns after AA would return same index value of 26. Fixed.