Skip to content

fix(proxy): check hostname allowlist before DNS resolution - #1675

Merged
SequeI merged 1 commit into
mainfrom
fixDNS
Aug 19, 2026
Merged

SequeI merged 1 commit into
mainfrom
fixDNS

Conversation

@SequeI

@SequeI SequeI commented Aug 19, 2026

Copy link
Copy Markdown
Member

Linked Issue

Closes #

Summary

Test Plan

Checklist

  • An issue exists and is linked above
  • All commits are signed-off, using DCO
  • All new code follows the project's coding standards (CLAUDE.md) and is covered by tests
  • Public-facing changes are paired with documentation updates

Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
@github-actions github-actions Bot added bug Something isn't working nono-proxy size/medium labels Aug 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Review Summary

Size

Metric Value
Lines added +53
Lines removed -11
Total changed 64
Classification Medium (50–300 lines)

Affected crates

  • crates/nono-proxydownstream consumers depend on this crate. API or behaviour changes will affect external callers; treat any breaking change with extra scrutiny.

Blast radius — Contained

This PR touches: source code


Updated automatically on each push to this PR.

@nogent-nolabs-ai nogent-nolabs-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nogent code review

No blocking issues or bugs found; 0 findings.

Findings: none flagged in scope.

Automated code + security review. CI already covers clippy, rustfmt, tests, cargo-audit and commit-lint.

@SequeI
SequeI requested review from connrg, kurtisc and lukehinds August 19, 2026 09:29
@SequeI
SequeI merged commit cae89a0 into main Aug 19, 2026
18 checks passed
@SequeI
SequeI deleted the fixDNS branch August 26, 2026 15:38
levonk pushed a commit to levonk/nono that referenced this pull request Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working nono-proxy size/medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants