Skip to content

src: add initial poll_oneoff() implementation - #117

Merged
cjihrig merged 2 commits into
masterfrom
poll
May 10, 2020
Merged

src: add initial poll_oneoff() implementation#117
cjihrig merged 2 commits into
masterfrom
poll

Conversation

@cjihrig

@cjihrig cjihrig commented May 8, 2020

Copy link
Copy Markdown
Collaborator

The implementation is currently limited by what uv_poll_t's support.

Fixes: #12

Tested in the context of Node.js with a CI run.

cjihrig added 2 commits May 3, 2020 09:53
snapshot_preview2 added the constraint that poll_oneoff() should
return EINVAL if nsubscriptions is zero. Even though poll_oneoff()
isn't implemented yet, this commit adds the necessary input
validation.

Refs: #59
The implementation is currently limited by what
uv_poll_t's support.

Fixes: #12
@cjihrig
cjihrig merged commit 6f8e1e1 into master May 10, 2020
@cjihrig
cjihrig deleted the poll branch May 10, 2020 13:43
@cjihrig cjihrig mentioned this pull request May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

poll_oneoff() implementation

1 participant