Potential integration with wabt

[sbc100]

I started to investigate an integration with wabt. So far I have just the tiniest start with an implementation , just hooking up proc_exit:

WebAssembly/wabt#1411

I had a couple of questions:

1. What do you think is the best way for a project like wabt to build against uvwasi. The approach I took was to use add_subdirectory. However that resulted in an error because both uvwasi and wabt both define the custom check target. I hacked that target out locally and it seems to work.

2. Do users of uvwasi actually need the uv.h headers? Currently the public headers for uvwasi include the headers from the uv project. Perhaps that is unavoidable? It does mean that downstream projects need to add more include paths so it could be removed that would be a win.

[cjihrig]

What do you think is the best way for a project like wabt to build against uvwasi. The approach I took was to use add_subdirectory. However that resulted in an error because both uvwasi and wabt both define the custom check target. I hacked that target out locally and it seems to work.

It looks like uvwasi can add logic similar to this to only define those targets if it is the root project. In the mean time, does ExternalProject_Add work as suggested here?

Do users of uvwasi actually need the uv.h headers? Currently the public headers for uvwasi include the headers from the uv project. Perhaps that is unavoidable? It does mean that downstream projects need to add more include paths so it could be removed that would be a win.

I agree. I think it should be possible by moving some things around. I'll look into it.

[sbc100]

What do you think is the best way for a project like wabt to build against uvwasi. The approach I took was to use add_subdirectory. However that resulted in an error because both uvwasi and wabt both define the custom check target. I hacked that target out locally and it seems to work.

It looks like uvwasi can add logic similar to this to only define those targets if it is the root project. In the mean time, does ExternalProject_Add work as suggested here?

if you could make that change that would be awesome. I briefly looked at ExternalProject_Add but it seemed a little heavyweight, and it doesn't look like it works with git submodules. Perhaps I should take another look.

Do users of uvwasi actually need the uv.h headers? Currently the public headers for uvwasi include the headers from the uv project. Perhaps that is unavoidable? It does mean that downstream projects need to add more include paths so it could be removed that would be a win.

I agree. I think it should be possible by moving some things around. I'll look into it.

Thanks!

[cjihrig]

FYI - I landed 89f039d earlier. I didn't close this out yet because the uv.h header part of this issue is still outstanding.

[sbc100]

Great! This worked for me. Thanks.