Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions doc/contributing/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,12 @@ $ git reset --hard upstream/vN.x
The list of patches to include should be listed in the "Next Security Release"
issue in `nodejs-private`. Ask the security release steward if you're unsure.

The `git node land` tool does not work with the `nodejs-private`
organization. To land a PR in Node.js private, use `git cherry-pick` to apply
each commit from the PR. You will also need to manually apply the PR
metadata (`PR-URL`, `Reviewed-by`, etc.) by amending the commit messages. If
To use the `git node land` tool to land Pull Requests in the `nodejs-private`
organization, you need to specify the full URL to the Pull Request and make sure
you provide a GitHub token with read permission to the private repository. If
known, additionally include `CVE-ID: CVE-XXXX-XXXXX` in the commit metadata.
Make sure to sign and push to resulting commit to the private repository and not
the public one.

**Note**: Do not run CI on the PRs in `nodejs-private` until CI is locked down.
You can integrate the PRs into the proposal without running full CI.
Expand Down
Loading