Skip to content

quic: expose QUIC certificates as JS X509Certificate, not raw handles#63191

Open
pimterry wants to merge 1 commit intonodejs:mainfrom
pimterry:fix-quic-peer-certificate
Open

quic: expose QUIC certificates as JS X509Certificate, not raw handles#63191
pimterry wants to merge 1 commit intonodejs:mainfrom
pimterry:fix-quic-peer-certificate

Conversation

@pimterry
Copy link
Copy Markdown
Member

@pimterry pimterry commented May 8, 2026

Starting to work through the TLS implementation in QUIC, one nice small standalone fix here.

@pimterry pimterry requested a review from jasnell May 8, 2026 11:13
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels May 8, 2026
Signed-off-by: Tim Perry <pimterry@gmail.com>
@pimterry pimterry force-pushed the fix-quic-peer-certificate branch from 13e1c27 to 4478d4b Compare May 8, 2026 11:28
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (b5da751) to head (4478d4b).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #63191    +/-   ##
========================================
  Coverage   90.03%   90.04%            
========================================
  Files         713      713            
  Lines      224510   224943   +433     
  Branches    42438    42528    +90     
========================================
+ Hits       202148   202542   +394     
- Misses      14163    14179    +16     
- Partials     8199     8222    +23     
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <100.00%> (ø)

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants