module: exclude node:ffi from builtinModules when flag is disabled#63158
Merged
aduh95 merged 2 commits intonodejs:mainfrom May 6, 2026
Merged
module: exclude node:ffi from builtinModules when flag is disabled#63158aduh95 merged 2 commits intonodejs:mainfrom
aduh95 merged 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Module.builtinModules is supposed to only list modules that are accessible to user code. node:ffi requires --experimental-ffi to be required, so filter it out when the flag is not set, mirroring the existing handling for --experimental-quic. Refs: nodejs#63137 (comment) Signed-off-by: Jordan Harband <ljharb@gmail.com>
798219d to
999efeb
Compare
aduh95
approved these changes
May 6, 2026
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
This comment was marked as outdated.
This comment was marked as outdated.
targos
approved these changes
May 6, 2026
Contributor
|
Related failure to address: |
panva
approved these changes
May 6, 2026
JakobJingleheimer
approved these changes
May 6, 2026
Collaborator
lpinca
approved these changes
May 6, 2026
bengl
approved these changes
May 6, 2026
Member
Author
|
@aduh95 thanks, fixed! |
cc2a346 to
29fb725
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
|
the CI failure looks spurious? |
Contributor
|
It's a bit annoying that you force-pushed my commit out, it seems unlikely there will be time to include this PR in 26.1.0 now |
Member
Author
|
@aduh95 sorry; i didn't realize you'd pushed a commit. |
29fb725 to
cc2a346
Compare
Collaborator
Collaborator
Contributor
|
Landed in 2f5d7e7 |
aduh95
pushed a commit
that referenced
this pull request
May 6, 2026
`Module.builtinModules` is supposed to only list modules that are accessible to user code. `node:ffi` requires `--experimental-ffi` to be required, so filter it out when the flag is not set, mirroring the existing handling for `--experimental-quic`. Refs: #63137 (comment) Signed-off-by: Jordan Harband <ljharb@gmail.com> PR-URL: #63158 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63158 +/- ##
==========================================
- Coverage 90.04% 90.03% -0.01%
==========================================
Files 713 713
Lines 224484 224500 +16
Branches 42430 42421 -9
==========================================
+ Hits 202134 202136 +2
- Misses 14156 14162 +6
- Partials 8194 8202 +8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module.builtinModulesis supposed to only list modules that are accessible to user code. node:ffi requires--experimental-ffito be required, so filter it out when the flag is not set, mirroring the existing handling for--experimental-quic.Refs: #63137 (comment), #62072