Skip to content

tools: update nixpkgs-unstable to ab72be9733b41190ea34f1422a3e4e243ed#62821

Merged
nodejs-github-bot merged 1 commit intomainfrom
actions/tools-update-nixpkgs-unstable
Apr 21, 2026
Merged

tools: update nixpkgs-unstable to ab72be9733b41190ea34f1422a3e4e243ed#62821
nodejs-github-bot merged 1 commit intomainfrom
actions/tools-update-nixpkgs-unstable

Conversation

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot commented Apr 19, 2026 •
edited by aduh95
Loading

This is an automated update of nixpkgs-unstable to ab72be9733b41190ea34f1422a3e4e243ed.

@nodejs-github-bot nodejs-github-bot added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. tools Issues and PRs related to the tools directory. labels Apr 19, 2026
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 19, 2026
@aduh95 aduh95 force-pushed the actions/tools-update-nixpkgs-unstable branch from 8fc5df6 to dd8f89c Compare April 19, 2026 18:52
@aduh95 aduh95 changed the title tools: update nixpkgs-unstable to b86751bc4085f48661017fa226dee99fab6 tools: update nixpkgs-unstable to ab72be9733b41190ea34f1422a3e4e243ed Apr 19, 2026
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Apr 19, 2026 •
edited
Loading

Removed the revert of numtide/treefmt@b96016b now that the fix has landed upstream (tested on https://github.com/nodejs/node-auto-test/actions/runs/24636421675). Also bumped the version to one with openssl_4_0

@panva panva force-pushed the actions/tools-update-nixpkgs-unstable branch from dd8f89c to 9822fa1 Compare April 20, 2026 14:55
@panva panva requested a review from aduh95 April 20, 2026 14:55
@panva
tools: update nixpkgs-unstable to ab72be9733b41190ea34f1422a3e4e243ed
bd9ab76 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva force-pushed the actions/tools-update-nixpkgs-unstable branch from 9822fa1 to bd9ab76 Compare April 20, 2026 15:01
aduh95
aduh95 approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense for you to sign off something you did not author?

@panva
Copy link
Copy Markdown
Member

panva commented Apr 20, 2026

rebase from main changed the commit to me as the author, for some reason, so by policy i must sign off 😀. do you want to close this and trigger a fresh sync instead, or just tell me how to proceed.

@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Apr 20, 2026 •
edited
Loading

I see no reason to close this, I'm asking to try to avoid having to do that in the future. Not that the rebase did not change the authorship, you were already set as author of 8fc5df6. I've opened #62856 to address this.

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 21, 2026
@nodejs-github-bot nodejs-github-bot merged commit 3e32a13 into main Apr 21, 2026
22 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator Author

nodejs-github-bot commented Apr 21, 2026

Landed in 3e32a13

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-nixpkgs-unstable branch April 21, 2026 07:13
twoodslong
twoodslong reviewed Apr 21, 2026
View reviewed changes
Comment thread tools/nix/pkgs.nix
@Renegade334
Copy link
Copy Markdown
Member

Renegade334 commented May 3, 2026

Interestingly, the intermittent lint-nix timeouts appear to have recurred since this commit.

@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented May 3, 2026 •
edited
Loading

I did another test:

13 timeout over 512 runs is roughly 2.5%, which is not nothing, but all things considered 97.5% of reliability is a pretty high score for a Node.js CI :p

In numtide/treefmt#677 (comment), I have found very different figures, so I wonder if there's something else affecting the reliability.

aduh95 pushed a commit that referenced this pull request May 5, 2026
@nodejs-github-bot @aduh95
tools: update nixpkgs-unstable to ab72be9733b41190ea34f1422a3e4e243ed
48bb51b 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #62821
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 mentioned this pull request May 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

+1 more reviewer

@twoodslong twoodslong twoodslong left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nodejs-github-bot @aduh95 @panva @Renegade334 @cjihrig @twoodslong