fs: fix buffer input with recursive mode on readdir

[himself65]

Fixes: #58892

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner
• @nodejs/url

[codecov]

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.07%. Comparing base (04c5a18) to head (2bd843b).
⚠️ Report is 2889 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_file.cc	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59220      +/-   ##
==========================================
+ Coverage   90.04%   90.07%   +0.02%     
==========================================
  Files         648      648              
  Lines      191200   191234      +34     
  Branches    37472    37482      +10     
==========================================
+ Hits       172160   172247      +87     
+ Misses      11665    11606      -59     
- Partials     7375     7381       +6     

Files with missing lines	Coverage Δ
lib/fs.js	98.18% <100.00%> (+<0.01%)	⬆️
lib/internal/fs/utils.js	99.39% <100.00%> (+0.02%)	⬆️
src/node_file.cc	75.85% <0.00%> (-0.04%)	⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[himself65]

this might be not a good solution. let me find another way

[aduh95]

That's definitely a wrong solution, we need Buffer to support non-unicode paths

[himself65]

yeah, I see path = getValidatedPath(path); is a misleading code, the rest of the logic is pretending path is string but it's actually not. If I change getValidatedPath to support buffer + options.encoding I would guess it will have lot of performance regression

[himself65]

I think I find a good way

[github-actions]

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.