Skip to content

[v24.x] Backport doc deprecations#58542

Closed
targos wants to merge 2 commits intonodejs:v24.x-stagingfrom
targos:backport-deprecation-v24
Closed

[v24.x] Backport doc deprecations#58542
targos wants to merge 2 commits intonodejs:v24.x-stagingfrom
targos:backport-deprecation-v24

Conversation

@targos
Copy link
Copy Markdown
Member

@targos targos commented Jun 1, 2025

Includes:

mcollina and others added 2 commits June 1, 2025 09:10
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#58313
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Since priority signaling covers more than `http2Stream.priority`,
it makes more sense to rename the section.

There were also a few missing mentions in `http2.md`.

PR-URL: nodejs#58504
Refs: nodejs#58313
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Jun 1, 2025
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richardlau richardlau added lts-watch-v20.x lts-watch-v22.x PRs that may need to be released in v22.x labels Jun 1, 2025
@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jun 3, 2025
targos pushed a commit that referenced this pull request Jun 3, 2025
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #58313
Backport-PR-URL: #58542
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
targos pushed a commit that referenced this pull request Jun 3, 2025
Since priority signaling covers more than `http2Stream.priority`,
it makes more sense to rename the section.

There were also a few missing mentions in `http2.md`.

PR-URL: #58504
Backport-PR-URL: #58542
Refs: #58313
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos
Copy link
Copy Markdown
Member Author

targos commented Jun 3, 2025

Landed in 8a1eaea...2f555e0

@targos targos closed this Jun 3, 2025
@targos targos deleted the backport-deprecation-v24 branch June 3, 2025 08:02
aduh95 added a commit that referenced this pull request Jun 10, 2025
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #58313
Backport-PR-URL: #58542
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 added a commit that referenced this pull request Jun 10, 2025
Since priority signaling covers more than `http2Stream.priority`,
it makes more sense to rename the section.

There were also a few missing mentions in `http2.md`.

PR-URL: #58504
Backport-PR-URL: #58542
Refs: #58313
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed lts-watch-v22.x PRs that may need to be released in v22.x labels Jun 10, 2025
marco-ippolito pushed a commit that referenced this pull request Nov 19, 2025
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #58313
Backport-PR-URL: #58542
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Nov 19, 2025
Since priority signaling covers more than `http2Stream.priority`,
it makes more sense to rename the section.

There were also a few missing mentions in `http2.md`.

PR-URL: #58504
Backport-PR-URL: #58542
Refs: #58313
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported-to-v22.x PRs backported to the v22.x-staging branch. doc Issues and PRs related to the documentations. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants