lib: avoid event override by assignment - #58315
Conversation
3c64785 to
7729c3d
Compare
7729c3d to
a5dce87
Compare
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb
left a comment
There was a problem hiding this comment.
With this last comment, and with some tests (that install an inherited setter and verify it's not called, and then remove the setter, presumably) this PR LGTM
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58315 +/- ##
==========================================
- Coverage 89.87% 89.86% -0.01%
==========================================
Files 656 656
Lines 192956 192993 +37
Branches 37846 37842 -4
==========================================
+ Hits 173411 173429 +18
- Misses 12103 12110 +7
- Partials 7442 7454 +12
🚀 New features to boost your workflow:
|
|
This pull request has been marked as stale due to 90 days of inactivity. |
|
This PR is still relevant. @ljharb you LGTMed it. Did you also approve it? Do you have the power? Who should I ping to take a look at it? Who else should be a reviewer? |
See #43907