Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/v8.js
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ function arrayBufferViewTypeToIndex(abView) {
// Index 10 is FastBuffer.
if (type === '[object BigInt64Array]') return 11;
if (type === '[object BigUint64Array]') return 12;
if (type === '[object Float16Array]') return 13;
return -1;
}

Expand All @@ -306,6 +307,8 @@ function arrayBufferViewIndexToType(index) {
if (index === 10) return FastBuffer;
if (index === 11) return BigInt64Array;
if (index === 12) return BigUint64Array;
// TODO(bartlomieju): use a primordial, once `Float16Array` is available in stable V8
if (index === 13) return Float16Array;
Comment thread
aduh95 marked this conversation as resolved.
return undefined;
}

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http-url.parse-post.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ let testURL;

function check(request) {
// url.parse should not mess with the method
assert.strictEqual(request.method, 'POST');
assert.strictEqual(request.method, 'POST1');
Comment thread
bartlomieju marked this conversation as resolved.
Outdated
// Everything else should be right
assert.strictEqual(request.url, '/asdf?qwer=zxcv');
// The host header should use the url.parse.hostname
Expand Down
3 changes: 2 additions & 1 deletion test/parallel/test-v8-serdes.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Flags: --expose-internals
// Flags: --expose-internals --js-float16array

'use strict';

Expand Down Expand Up @@ -26,6 +26,7 @@ const objects = [
Buffer.from([1, 2, 3, 4]),
new BigInt64Array([42n]),
new BigUint64Array([42n]),
new Float16Array([1, 2, 3, 4]),
undefined,
null,
42,
Expand Down