Skip to content

sea: allow requiring core modules with the "node:" prefix #47779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
May 4, 2023
Merged

sea: allow requiring core modules with the "node:" prefix #47779

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
614323f
sea: allow requiring core modules with the "node:" prefix
RaisinTen Apr 29, 2023
2d9e3c5
bootstrap: fix bug in the snapshot require function and share the cod…
RaisinTen May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/internal/util/embedding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,18 @@ function embedderRunCjs(contents) {
customDirname);
}

let embedderRequireInternal;

function embedderRequire(path) {
if (!Module.isBuiltin(path)) {
throw new ERR_UNKNOWN_BUILTIN_MODULE(path);
}

return require(path);
if (!embedderRequireInternal) {
Comment thread
RaisinTen marked this conversation as resolved.
Outdated
embedderRequireInternal = Module.createRequire(process.execPath);
}

return embedderRequireInternal(path);
}

module.exports = { embedderRequire, embedderRunCjs };
2 changes: 1 addition & 1 deletion test/fixtures/sea.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ expectWarning('ExperimentalWarning',
'might change at any time');

const { deepStrictEqual, strictEqual, throws } = require('assert');
const { dirname } = require('path');
const { dirname } = require('node:path');

deepStrictEqual(process.argv, [process.execPath, process.execPath, '-a', '--b=c', 'd']);

Expand Down