module: CJS exports detection for all CJS modules#35249
Closed
guybedford wants to merge 4 commits intonodejs:masterfrom
Closed
module: CJS exports detection for all CJS modules#35249guybedford wants to merge 4 commits intonodejs:masterfrom
guybedford wants to merge 4 commits intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another PR for CommonJS named exports identical to #33416 but without the restriction to modules with the
__esModuleflag.This PR is made to separate the consensus process for this PR from the PR at #33416, which strictly speaking could land given that it now has consensus.
If all those involved could review this PR with their opinions on relaxing the
__esModulerestriction that would be a help to determine which if any approach might ship. This way we can clearly choose between the three choices.//cc @nodejs/modules-active-members