Skip to content

string_decoder: fix number of replacement chars - #22709

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:string-decoder
Closed

string_decoder: fix number of replacement chars#22709
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:string-decoder

Conversation

@addaleax

@addaleax addaleax commented Sep 5, 2018

Copy link
Copy Markdown
Member

Fixes: #22626

Tentatively labeling as semver-major.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added semver-major PRs that contain breaking changes and should be released in the next major version. string_decoder Issues and PRs related to the string_decoder subsystem. labels Sep 5, 2018
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2018

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/801/pipeline

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Sep 5, 2018
@addaleax addaleax removed the buffer Issues and PRs related to the buffer subsystem. label Sep 5, 2018
@addaleax

addaleax commented Sep 6, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17064/

@addaleax

addaleax commented Sep 9, 2018

Copy link
Copy Markdown
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17094/

This needs one more TSC review – not very urgent, though :)

@addaleax

addaleax commented Sep 17, 2018

Copy link
Copy Markdown
Member Author

Resume² CI: https://ci.nodejs.org/job/node-test-pull-request/17247/

Adding tsc-review, as a low-noise way to maybe attract another TSC reviewer?

@addaleax

addaleax commented Sep 18, 2018

Copy link
Copy Markdown
Member Author

Resume³ CI: https://ci.nodejs.org/job/node-test-pull-request/17289/

@addaleax

addaleax commented Sep 22, 2018

Copy link
Copy Markdown
Member Author

CI is green … @nodejs/tsc can somebody review this?

mcollina
mcollina approved these changes Sep 24, 2018
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 24, 2018
@addaleax

addaleax commented Sep 24, 2018

Copy link
Copy Markdown
Member Author

Landed in 06f6ac1, 1b27428

@addaleax addaleax closed this Sep 24, 2018
@addaleax
addaleax deleted the string-decoder branch September 24, 2018 20:22
addaleax added a commit that referenced this pull request Sep 24, 2018
@addaleax
string_decoder: fix number of replacement chars
06f6ac1 
Fixes: #22626

PR-URL: #22709
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit that referenced this pull request Sep 24, 2018
@addaleax
test: add string-decoder fuzz test
1b27428 
PR-URL: #22709
Fixes: #22626
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. semver-major PRs that contain breaking changes and should be released in the next major version. string_decoder Issues and PRs related to the string_decoder subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@addaleax @nodejs-github-bot @mcollina @jasnell @Trott @cjihrig @BridgeAR