Web Crypto API test and key import issues

[fhanau]

Version

v20.1.0

Platform

No response

Subsystem

crypto.webcrypto

What steps will reproduce the bug?

No response

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

While looking at Node's crypto API, I found some potential issues in the Web Crypto tests:

• node/test/parallel/test-webcrypto-wrap-unwrap.js

  Line 301 in 27467a8

  return testWrapping(name, keys);

  In the Wrap-Unwrap tests, the mapping returns the tests instead of adding them to the variations list, this causes the tests in this file to not actually run.

• node/test/parallel/test-webcrypto-sign-verify-eddsa.js

  Line 146 in 27467a8

  subtle.importKey(

  Here we import a private EdDsa key with empty usages. Based on the Web Crypto spec this is not allowed, when importing a private key the usages must not be empty. This also indicates a bug in the implementation as the test cases require non-conforming behavior. Based on a brief search of the code, the test-webcrypto-sign-verify-ecdsa.js and test-webcrypto-sign-verify-rsa.js tests may also be affected.

• node/test/parallel/test-webcrypto-export-import-cfrg.js

  Line 311 in 27467a8

  publicUsages),

  Less important, but this should be privateUsages.

@jasnell

Additional information

No response

[tniessen]

cc @panva

[panva]

I'll have a look later today.

[panva]

Thank you @fhanau, I've opened individual PRs to address each point.

[fhanau]

You're welcome, thanks for the quick response!