Skip to content

Rename signingCert -> publicCert and signingKey -> privateKey - #315

Merged
cjbarth merged 1 commit into
node-saml:masterfrom
cjbarth:property-rename
Jun 18, 2023
Merged

Rename signingCert -> publicCert and signingKey -> privateKey#315
cjbarth merged 1 commit into
node-saml:masterfrom
cjbarth:property-rename

Conversation

@cjbarth

@cjbarth cjbarth commented Jun 17, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jun 17, 2023

Copy link
Copy Markdown

Codecov Report

Merging #315 (d75155b) into master (c2b83f9) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   82.74%   82.74%           
=======================================
  Files           5        5           
  Lines         875      875           
=======================================
  Hits          724      724           
  Misses        151      151           
Impacted Files Coverage Δ
lib/signed-xml.js 83.36% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LoneRifle LoneRifle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise. Interesting to know that this package may have been modelled after its dotnet equivalent.

Comment thread test/validators/XmlCryptoUtilities/XmlCryptoUtilities/utilities.cs Outdated
@cjbarth

cjbarth commented Jun 18, 2023

Copy link
Copy Markdown
Contributor Author

It certainly was built on the .Net mode, but, I think we'd all agree, no one praises the .Net model for its simplicity. What is more, it seems like the interface really hides a lot of complexity under the hood; complexity that we just don't have the resources to develop or maintain.

I think I'm happy with the direction we've taken this and I think it gives us room to move forward with the kinds of use-cases that those using this project are encountering.

@cjbarth
cjbarth merged commit 78329fb into node-saml:master Jun 18, 2023
@cjbarth
cjbarth deleted the property-rename branch June 18, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: deprecate SignedXml.signingKey in favor of SignedXml.publicKey and SignedXml.privateKey

2 participants